Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

P0053R7 <syncstream> #3

Closed
StephanTLavavej opened this issue Sep 5, 2019 · 2 comments · Fixed by #1564
Closed

P0053R7 <syncstream> #3

StephanTLavavej opened this issue Sep 5, 2019 · 2 comments · Fixed by #1564
Labels
cxx20 C++20 feature fixed Something works now, yay!
Milestone
Conformance

Comments

@StephanTLavavej
Copy link
Member

StephanTLavavej commented Sep 5, 2019 •
edited
Loading

P0053R7 <syncstream>
P0753R2 osyncstream Manipulators

LWG-3127 basic_osyncstream::rdbuf needs a const_cast
LWG-3253 basic_syncbuf::basic_syncbuf() should not be explicit
LWG-3334 basic_osyncstream move assignment and destruction calls basic_syncbuf::emit() twice

Feature-test macro as of WG21-N4842, added by WG21-P1902:
#define __cpp_lib_syncbuf 201803L
@StephanTLavavej StephanTLavavej added the cxx20 C++20 feature label Sep 5, 2019
@StephanTLavavej
Copy link
Member Author

Qt reportedly macroizes emit so we will probably need push_macro defenses.

@cbezault cbezault added this to the Conformance milestone May 7, 2020
@MahmoudGSaleh MahmoudGSaleh mentioned this issue Jul 30, 2020
Open
@MichaelRizkalla
Copy link
Contributor

I am starting to work on P0053R7, just checking if I can pick it up since this is an entirely new header 🤔.
I have an initial basic_syncbuf's implementation in 30a999b,

@MichaelRizkalla MichaelRizkalla mentioned this issue Jan 11, 2021
Merged
6 tasks
@StephanTLavavej StephanTLavavej added fixed Something works now, yay! and removed work in progress labels Feb 19, 2021
@philnik777 philnik777 mentioned this issue Jun 2, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cxx20 C++20 feature fixed Something works now, yay!
Projects
None yet
Milestone
Conformance
Development

Successfully merging a pull request may close this issue.

<syncstream>: implement basic_syncbuf and basic_osyncstream
3 participants
@cbezault @StephanTLavavej @MichaelRizkalla