Issues needed for skipped libcxx tests

[MahmoudGSaleh]

The set of skipped libcxx tests in tests/libcxx/skipped_tests.txt contain a number of tests skipped due to STL bugs that have no corresponding GitHub issues. The set of such bugs is included under # *** STL BUGS ***.

We need to open a new GitHub issue for each of the ones below (or link to one if already exists). In addition to clear title, description, test case and expected behavior, we need to add skipped test information in the additional context, so it can be enabled once the bug is fixed. The first two, GH-1112 and GH-1113, can be used as examples.

✔️ Issue Filed

• <locale>: the enum value of std::money_base is not correct #1112
  

  STL/tests/libcxx/expected_results.txt

  Lines 550 to 551 in 06827fe

  	# STL bug: VSO-121977 "<locale>: the enum value of std::money_base is not correct[libcxx]"
  	std/localization/locale.categories/category.monetary/locale.moneypunct/money_base.pass.cpp FAIL

• <fstream>: basic_filebuf doesn't comply with setbuf(0,0) requirement in the standard #1113
  

  STL/tests/libcxx/expected_results.txt

  Lines 553 to 555 in 06827fe

  	# STL Bug: VSO-595631 <fstream> basic_filebuf doesn't comply with setbuf(0,0) requirement in the standard
  	std/input.output/file.streams/fstreams/filebuf.virtuals/overflow.pass.cpp FAIL
  	std/input.output/file.streams/fstreams/filebuf.virtuals/underflow.pass.cpp FAIL

• <complex>: invalid conversions allowed #1256
  

  STL/tests/libcxx/expected_results.txt

  Lines 557 to 560 in 06827fe

  	# STL bug: Our inheritance implementation is allowing this to compile when it shouldn't.
  	std/numerics/complex.number/complex.special/double_long_double_implicit.compile.fail.cpp FAIL
  	std/numerics/complex.number/complex.special/float_double_implicit.compile.fail.cpp FAIL
  	std/numerics/complex.number/complex.special/float_long_double_implicit.compile.fail.cpp FAIL

• <regex>: Error C2664 in std::regex_traits::transform #1004
  

  STL/tests/libcxx/expected_results.txt

  Lines 562 to 563 in 06827fe

  	# STL bug: regex_traits::transform() isn't following the Standard.
  	std/re/re.traits/transform.pass.cpp FAIL

• <array>: std::array<T,0> doesn't compile - when type is not default constructible #942
  

  STL/tests/libcxx/expected_results.txt

  Lines 572 to 574 in 06827fe

  	# STL bug: We allow fill() and swap() for array<const T, 0>.
  	std/containers/sequences/array/array.fill/fill.fail.cpp FAIL
  	std/containers/sequences/array/array.swap/swap.fail.cpp FAIL

• <array>: std::array<T,0> doesn't compile - when type is not default constructible #942
  

  STL/tests/libcxx/expected_results.txt

  Lines 576 to 581 in 06827fe

  	# STL bug: VSO-207715 We reject array<NoDefault, 0>.
  	std/containers/sequences/array/array.cons/implicit_copy.pass.cpp FAIL
  	std/containers/sequences/array/array.cons/initialization.pass.cpp FAIL
  	std/containers/sequences/array/array.data/data_const.pass.cpp FAIL
  	std/containers/sequences/array/array.data/data.pass.cpp FAIL
  	std/containers/sequences/array/iterators.pass.cpp FAIL

• <algorithm>: debug checks for predicates are observable #1006
  

  STL/tests/libcxx/expected_results.txt

  Lines 586 to 589 in 06827fe

  	# Predicate count assertions - IDL2 is slightly bending the Standard's rules here.
  	std/algorithms/alg.sorting/alg.heap.operations/make.heap/make_heap_comp.pass.cpp FAIL
  	std/algorithms/alg.sorting/alg.merge/inplace_merge_comp.pass.cpp FAIL
  	std/algorithms/alg.sorting/alg.min.max/minmax_init_list_comp.pass.cpp FAIL

• <locale>: wrong field extraction for hexfloats, or special cases like inf #1259
  

  STL/tests/libcxx/expected_results.txt

  Lines 591 to 594 in 06827fe

  	# STL bug: We don't match strtod / strtof when doing field extraction for hexfloats, or special cases like inf
  	std/localization/locale.categories/category.numeric/locale.num.get/facet.num.get.members/get_double.pass.cpp FAIL
  	std/localization/locale.categories/category.numeric/locale.num.get/facet.num.get.members/get_float.pass.cpp FAIL
  	std/localization/locale.categories/category.numeric/locale.num.get/facet.num.get.members/get_long_double.pass.cpp FAIL

• <system_error>: error_category's default ctor isn't constexpr.  #1116
  

  STL/tests/libcxx/expected_results.txt

  Lines 634 to 635 in 06827fe

  	# STL Bug: error_category's default ctor isn't constexpr. (Should be fixed in vNext.)
  	std/diagnostics/syserr/syserr.errcat/syserr.errcat.nonvirtuals/default_ctor.pass.cpp:1 FAIL

• <future>: incorrectly used copy assignment instead of copy construction in set_value #1190
  

  STL/tests/libcxx/expected_results.txt

  Lines 637 to 638 in 06827fe

  	# STL Bug: future incorrectly uses copy assignment instead of copy construction in set_value. (Should be fixed in vNext.)
  	std/thread/futures/futures.promise/set_value_const.pass.cpp FAIL

• <xstring>: Too many enabled hash specializations #757
  

  STL/tests/libcxx/expected_results.txt

  Lines 640 to 642 in 06827fe

  	# STL bug: GH-757 <xstring>: Too many enabled hash specializations
  	std/strings/basic.string.hash/char_type_hash.fail.cpp FAIL
  	std/strings/string.view/string.view.hash/char_type.hash.fail.cpp FAIL

• <type_traits>: aligned_storage has incorrect alignment defaults #784
  

  STL/tests/libcxx/expected_results.txt

  Lines 644 to 645 in 06827fe

  	# STL bug: GH-784 <type_traits>: aligned_storage has incorrect alignment defaults
  	std/utilities/meta/meta.trans/meta.trans.other/aligned_storage.pass.cpp FAIL

• <complex>: pow, incorrect type conversion #1260
  

  STL/tests/libcxx/expected_results.txt

  Lines 565 to 566 in 06827fe

  	# STL bug: Incorrect return types.
  	std/numerics/complex.number/cmplx.over/pow.pass.cpp FAIL

• <locale>: wbuffer_convert does not implement seek #1264
  

  STL/tests/libcxx/expected_results.txt

  Lines 631 to 632 in 06827fe

  	# STL Bug? Our wbuffer_convert does not implement seek. [depr.conversions.buffer] is completely underspecified.
  	std/localization/locales/locale.convenience/conversions/conversions.buffer/seekoff.pass.cpp FAIL

• <locale>: missing some locale names #1275
  

  STL/tests/libcxx/expected_results.txt

  Lines 599 to 629 in 06827fe

  	# STL test bug: We don't have the locale names libcxx wants specialized in platform_support.hpp
  	# More bugs may be uncovered when the locale names are present.
  	# move.pass.cpp can crash.
  	std/input.output/iostreams.base/ios/basic.ios.members/move.pass.cpp SKIPPED
  	std/localization/locale.categories/category.collate/locale.collate.byname/compare.pass.cpp FAIL
  	std/localization/locale.categories/category.ctype/locale.ctype.byname/is_1.pass.cpp FAIL
  	std/localization/locale.categories/category.ctype/locale.ctype.byname/is_many.pass.cpp FAIL
  	std/localization/locale.categories/category.ctype/locale.ctype.byname/narrow_1.pass.cpp FAIL
  	std/localization/locale.categories/category.ctype/locale.ctype.byname/narrow_many.pass.cpp FAIL
  	std/localization/locale.categories/category.ctype/locale.ctype.byname/scan_is.pass.cpp FAIL
  	std/localization/locale.categories/category.ctype/locale.ctype.byname/scan_not.pass.cpp FAIL
  	std/localization/locale.categories/category.ctype/locale.ctype.byname/widen_1.pass.cpp FAIL
  	std/localization/locale.categories/category.ctype/locale.ctype.byname/widen_many.pass.cpp FAIL
  	std/localization/locale.categories/category.monetary/locale.moneypunct.byname/curr_symbol.pass.cpp FAIL
  	std/localization/locale.categories/category.monetary/locale.moneypunct.byname/decimal_point.pass.cpp FAIL
  	std/localization/locale.categories/category.monetary/locale.moneypunct.byname/grouping.pass.cpp FAIL
  	std/localization/locale.categories/category.monetary/locale.moneypunct.byname/neg_format.pass.cpp FAIL
  	std/localization/locale.categories/category.monetary/locale.moneypunct.byname/negative_sign.pass.cpp FAIL
  	std/localization/locale.categories/category.monetary/locale.moneypunct.byname/pos_format.pass.cpp FAIL
  	std/localization/locale.categories/category.monetary/locale.moneypunct.byname/thousands_sep.pass.cpp FAIL
  	std/localization/locale.categories/category.time/locale.time.get.byname/get_date.pass.cpp FAIL
  	std/localization/locale.categories/category.time/locale.time.get.byname/get_date_wide.pass.cpp FAIL
  	std/localization/locale.categories/category.time/locale.time.get.byname/get_monthname.pass.cpp FAIL
  	std/localization/locale.categories/category.time/locale.time.get.byname/get_monthname_wide.pass.cpp FAIL
  	std/localization/locale.categories/category.time/locale.time.get.byname/get_one.pass.cpp FAIL
  	std/localization/locale.categories/category.time/locale.time.get.byname/get_one_wide.pass.cpp FAIL
  	std/localization/locale.categories/category.time/locale.time.get.byname/get_weekday.pass.cpp FAIL
  	std/localization/locale.categories/category.time/locale.time.get.byname/get_weekday_wide.pass.cpp FAIL
  	std/localization/locale.categories/category.time/locale.time.put.byname/put1.pass.cpp FAIL
  	std/localization/locale.categories/facet.numpunct/locale.numpunct.byname/grouping.pass.cpp FAIL
  	std/localization/locale.categories/facet.numpunct/locale.numpunct.byname/thousands_sep.pass.cpp FAIL

😸 Fixed

• <valarray>: slice_array's copy ctor is missing, the same with mask_array, gslice_array, indirect_array #940
  

  STL/tests/libcxx/expected_results.txt

  Lines 568 to 570 in 06827fe

  	# STL bug: Missing <valarray> assignment operators.
  	std/numerics/numarray/template.mask.array/mask.array.assign/mask_array.pass.cpp FAIL
  	std/numerics/numarray/template.slice.array/slice.arr.assign/slice_array.pass.cpp FAIL

• <string_view>: doesn't enforce "non-array trivial standard-layout" #1261
  

  STL/tests/libcxx/expected_results.txt

  Lines 583 to 584 in 06827fe

  	# STL bug: string_view doesn't enforce "non-array trivial standard-layout", related to LWG-3034.
  	std/strings/string.view/char.bad.fail.cpp:0 FAIL

[StephanTLavavej]

All done! Thanks @fsb4000 and @AlexGuteniev!