[CI] - problem building on Visual Studio 2022 Preview v17.13.0 Preview 4.0

[mikeclayton]

Microsoft PowerToys version

main

Installation method

GitHub

Running as admin

None

Area(s) with issue?

General

Steps to reproduce

Trying to build the main branch of the PowerToys solution in Visual Studio 2022 Preview v17.13.0 Preview 4.0 results in the following errors from the ApplicationUpdate project:

Severity	Code	Description	Project	File	Line	Suppression State
Error	C2039	'make_unexpected': is not a member of 'nonstd'	ApplicationUpdate	C:\src\github\microsoft\PowerToys\src\common\updating\updating.cpp	90
Error	C3861	'make_unexpected': identifier not found	ApplicationUpdate	C:\src\github\microsoft\PowerToys\src\common\updating\updating.cpp	90
Error	C2039	'make_unexpected': is not a member of 'nonstd'	ApplicationUpdate	C:\src\github\microsoft\PowerToys\src\common\updating\updating.cpp	142
Error	C3861	'make_unexpected': identifier not found	ApplicationUpdate	C:\src\github\microsoft\PowerToys\src\common\updating\updating.cpp	142
Error	C2672	'std::experimental::coroutine_traits<std::future<std::expectedupdating::github_version_info,std::wstring>,bool>::promise_type::return_value': no matching overloaded function found	ApplicationUpdate	C:\src\github\microsoft\PowerToys\src\common\updating\updating.cpp	90
Error	C2672	'std::experimental::coroutine_traits<std::future<std::expectedupdating::github_version_info,std::wstring>,bool>::promise_type::return_value': no matching overloaded function found	ApplicationUpdate	C:\src\github\microsoft\PowerToys\src\common\updating\updating.cpp	142

Building the same solution in Microsoft Visual Studio Professional 2022 v17.12.4 works fine by comparison.

To reproduce:

• check out the PowerToys repo into a new folder
• install submodules per https://github.com/microsoft/PowerToys/tree/main/doc/devdocs
  • git submodule update --init --recursive
• open PowerToys.sln in Visual Studio 2022 Preview v17.13.0 Preview 4.0
• build the solution

Note that the errors disappear if you subsequently build the solution in Microsoft Visual Studio Professional 2022 v17.12.4. However if you perform a "clean" on the ApplicationUpdate project and try to build it again in Preview v17.13.0 Preview 4.0 the error reappears.

I'm not a C / C++ dev so I'm struggling to find a root cause or fix (other than the build in Pro first and then switch back to Preview), but it looks like it's related to the expected-lite submodule - possibly compatibility with different versions of MSVC compiler?

In VS Pro 17.12.4 the version of MSVC in "detailed" build logs is 14.42.34433 (C:\Program Files\Microsoft Visual Studio\2022\Professional\VC\Tools\MSVC\14.42.34433\bin\HostX64\x64\CL.exe), but in VS 17.13.0 Preview 4,0 it's 14.43.34808 (C:\Program Files\Microsoft Visual Studio\2022\Preview\VC\Tools\MSVC\14.43.34808\bin\HostX64\x64\CL.exe) - I'm not sure if that's relevant though.

✔️ Expected Behavior

Build completes successfully in Visual Studio 2022 Preview v17.13.0 Preview 4.0

❌ Actual Behavior

Build fails with above errors.

Other Software

No response

[similar-issues-ai]

We've found some similar issues:

• [CI] - build fails in Visual Studio 17.6.0 Preview 3.0 - C1214 - Modules conflict with '/Zc:twoPhase-' #25526 , similarity score: 82%

If any of the above are duplicates, please consider closing this issue out and adding additional context in the original issue.

Note: You can give me feedback by 👍 or 👎 this comment.

[mikeclayton]

The "similar issue above" is similar in that it's a build issue with a Preview version of Visual Studio but I suspect the root cause is different this time.

[LNKLEO]

looked inside the header file, after may be 17.16 preview 2? MSVC begin to provide C++23 std::excepted with <excepted>, and excepted-lite will check this, and take it as default

just change C++ standard to C++20, before C++23 std::excepted fully developed

[LNKLEO]

looked inside the header file, after may be 17.16 preview 2? MSVC begin to provide C++23 std::excepted with , and excepted-lite will check this, and take it as default

just change C++ standard to C++20, before C++23 std::excepted fully developed

after a deep research, MSVC introduce C++ <excepted> beginning from 17.3/MSVC 14.33 (or 1933), the problem is that expected-lite constructing a excepted/unexpected with a make_XXX() function, but ISO C++ standard using a constructor without provide a make_XXX() func.

and I have make a PR for this compatibility