Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

export of MSFT_AADApplicationOnPremisesPublishingSingleSignOnSetting broken if kerberosSignOnSettings = $null #5715

Closed
slaurentpco opened this issue Feb 3, 2025 · 5 comments

Comments

@slaurentpco
Copy link

Description of the issue

When I export AADApplication with version 1.25.129.3, I get the following config (excerpt):

        AADApplication "AADApplication-REDACTED"
        {
...
            OnPremisesPublishing    = MSFT_AADApplicationOnPremisesPublishing{
                externalAuthenticationType = 'aadPreAuthentication'
                isPersistentCookieEnabled = $False
                internalUrl = 'https://REDACTED/'
                isTranslateHostHeaderEnabled = $True
                singleSignOnSettings = MSFT_AADApplicationOnPremisesPublishingSingleSignOnSetting{
                    singleSignOnMode = 'none'
                    kerberosSignOnSettings = $null

                }
..

Then when I try to call ConvertTo-DSCObject on the resulting M365TenantConfig.ps1 file, I get this error:

Unable to find type [Instance].

If I remove the line kerberosSignOnSettings = $null then it's OK.

My guess is that Export-M365DSCConfiguration should not write this line in M365TenantConfig.ps1...

Microsoft 365 DSC Version

1.25.129.3

Which workloads are affected

Azure Active Directory (Entra ID)

The DSC configuration

AADApplication "AADApplication-REDACTED"
        {
...
            OnPremisesPublishing    = MSFT_AADApplicationOnPremisesPublishing{
                externalAuthenticationType = 'aadPreAuthentication'
                isPersistentCookieEnabled = $False
                internalUrl = 'https://REDACTED/'
                isTranslateHostHeaderEnabled = $True
                singleSignOnSettings = MSFT_AADApplicationOnPremisesPublishingSingleSignOnSetting{
                    singleSignOnMode = 'none'
                    kerberosSignOnSettings = $null

                }
..

Verbose logs showing the problem


Environment Information + PowerShell Version

OsName               : Microsoft Windows 10 Enterprise
OsOperatingSystemSKU : EnterpriseEdition
OsArchitecture       : 64-bit
WindowsVersion       : 2009
WindowsBuildLabEx    : 19041.1.amd64fre.vb_release.191206-1406
OsLanguage           : en-GB
OsMuiLanguages       : {en-GB}

Name                           Value
----                           -----
PSVersion                      7.4.6
PSEdition                      Core
GitCommitId                    7.4.6
OS                             Microsoft Windows 10.0.19045
Platform                       Win32NT
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0…}
PSRemotingProtocolVersion      2.3
SerializationVersion           1.1.0.1
WSManStackVersion              3.0
@slaurentpco
Copy link
Author

I guess it's also fixed by #5746 . Thanks @FabienTschanz

@FabienTschanz
Copy link
Collaborator

Thank you for the confirmation. Do you mind closing the issue then?

@slaurentpco
Copy link
Author

I did not test the fix, I only use released versions...

@FabienTschanz
Copy link
Collaborator

@slaurentpco Version is now released - Feel free to try again.

@slaurentpco
Copy link
Author

all OK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants