From 6ca1dba8b348699795403b49fbf00b91a82d4496 Mon Sep 17 00:00:00 2001 From: Brian Kroth Date: Fri, 28 Jun 2024 18:48:49 -0500 Subject: [PATCH] Cleanup a warning issued by the SmacOptimizer cleanup code (#767) Minor tweak to address this warning in pytest output: ``` mlos_core/mlos_core/tests/optimizers/optimizer_multiobj_test.py::test_multi_target_opt_wrong_weights[SmacOptimizer-kwargs2] C:\Users\bpkroth\.conda\envs\mlos\Lib\site-packages\_pytest\unraisableexception.py:80: PytestUnraisableExceptionWarning: Exception ignored in: Traceback (most recent call last): File "C:\Users\bpkroth\src\MLOS\mlos_core\mlos_core\optimizers\bayesian_optimizers\smac_optimizer.py", line 208, in __del__ self.cleanup() File "C:\Users\bpkroth\src\MLOS\mlos_core\mlos_core\optimizers\bayesian_optimizers\smac_optimizer.py", line 339, in cleanup if self._temp_output_directory is not None: ^^^^^^^^^^^^^^^^^^^^^^^^^^^ AttributeError: 'SmacOptimizer' object has no attribute '_temp_output_directory' warnings.warn(pytest.PytestUnraisableExceptionWarning(msg)) mlos_core/mlos_core/tests/optimizers/optimizer_test.py: 135 warnings ``` Co-authored-by: Sergiy Matusevych --- .../mlos_core/optimizers/bayesian_optimizers/smac_optimizer.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mlos_core/mlos_core/optimizers/bayesian_optimizers/smac_optimizer.py b/mlos_core/mlos_core/optimizers/bayesian_optimizers/smac_optimizer.py index 43803b7dbb6..7bc7740a61e 100644 --- a/mlos_core/mlos_core/optimizers/bayesian_optimizers/smac_optimizer.py +++ b/mlos_core/mlos_core/optimizers/bayesian_optimizers/smac_optimizer.py @@ -336,7 +336,7 @@ def acquisition_function(self, *, configs: pd.DataFrame, context: Optional[pd.Da return self.base_optimizer._config_selector._acquisition_function(cs_configs).reshape(-1,) def cleanup(self) -> None: - if self._temp_output_directory is not None: + if hasattr(self, '_temp_output_directory') and self._temp_output_directory is not None: self._temp_output_directory.cleanup() self._temp_output_directory = None