Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can saved binary file be used if max_bin changes? #3577

Closed
cyfdecyf opened this issue Nov 17, 2020 · 4 comments
Closed

Can saved binary file be used if max_bin changes? #3577

cyfdecyf opened this issue Nov 17, 2020 · 4 comments

Comments

@cyfdecyf
Copy link
Contributor

I'm modifying the source code to add a new task "save_binary" to prepare data before running parameter tuning. The python package's Dataset.save_binary uses too much memory, thus I'd rather do it using cli version with two_round=true and force_col_wise=true.

I see max_bin and BinMapper are saved in binary file. So I'm wondering whether binary file can be reused if I change the max_bin parameter to a different value than when save the file?

@guolinke
Copy link
Collaborator

The max_bin will be fixed after save_binary, and you cannot update it.

@cyfdecyf
Copy link
Contributor Author

@guolinke Thanks for your reply.

I opened a pull request #3592 to prevent binary file with non-matching parameters from being used.

@StrikerRUS
Copy link
Collaborator

Fixed via #3592.

@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants