Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] diskannpy: batch_search is mistyped #433

Closed
bddap opened this issue Aug 18, 2023 · 2 comments · Fixed by #444
Closed

[BUG] diskannpy: batch_search is mistyped #433

bddap opened this issue Aug 18, 2023 · 2 comments · Fixed by #444
Assignees
@daxpryce
Labels
bug Something isn't working

Comments

@bddap
Copy link

bddap commented Aug 18, 2023

Expected Behavior

According to its type annotations, batch_search is expected to return a named tuple.

Actual Behavior

It returns a normal tuple.
@bddap bddap added the bug Something isn't working label Aug 18, 2023
@bddap
Copy link
Author

bddap commented Aug 18, 2023

Might want to check static_memory_index and _dynamic_memory_index too.

@daxpryce
Copy link
Contributor

Oh man thank you for this. I'll get a fix out asap

@daxpryce daxpryce self-assigned this Aug 29, 2023
@daxpryce daxpryce mentioned this issue Aug 29, 2023
Merged
5 tasks
@daxpryce daxpryce mentioned this issue Aug 30, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@daxpryce daxpryce

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Python type hints and returns actually align this time. microsoft/DiskANN
2 participants
@daxpryce @bddap