Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breakpoint source location matching with Chrome DevTools #63

Open
mjrgh opened this issue Nov 21, 2018 · 0 comments
Open

Breakpoint source location matching with Chrome DevTools #63

mjrgh opened this issue Nov 21, 2018 · 0 comments

Comments

@mjrgh
Copy link

mjrgh commented Nov 21, 2018

The Chrome DevTools debugger seems to send set-breakpoint-by-URL requests with the file:/// prefix stripped out of the URL. This prevents breakpoints from ever getting set in the engine, because DebuggerBreakpoint::IsScriptMatch() matches on exact URL string. Matching "file:///X" to "X" and vice versa in that routine fixes it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant