initial kernel config changes for criu #3300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
NikolaBo
force-pushed
the
t-nbojanic/criu-kernel-config
branch
from
0df32e7 to
b35ba7e
Compare
|
Mirrored code from fork and ran pipeline to test: https://dev.azure.com/mariner-org/mariner/_build/results?buildId=233401&view=results |
rlmenge
reviewed
Sep 7, 2022
| @@ -208,7 +208,7 @@ CONFIG_IPC_NS=y | |||
| CONFIG_USER_NS=y | |||
| CONFIG_PID_NS=y | |||
| CONFIG_NET_NS=y | |||
| # CONFIG_CHECKPOINT_RESTORE is not set | |||
| CONFIG_CHECKPOINT_RESTORE=y | |||
There was a problem hiding this comment.
Out of curiosity, do you know if this increases the size of the rpm significantly?
There was a problem hiding this comment.
RPM size is about 35M before and after the change.
Before: 36276851
After: 36312290
There was a problem hiding this comment.
Kernel boot time is also essentially unchanged: Startup finished in 1.364s (kernel) with the changes and Startup finished in 1.362s (kernel) without (from systemd-analyze).
neha170
approved these changes
Sep 7, 2022
rlmenge
approved these changes
Sep 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge Checklist
All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)
*-staticsubpackages, etc.) have had theirReleasetag incremented../cgmanifest.json,./toolkit/tools/cgmanifest.json,./toolkit/scripts/toolchain/cgmanifest.json,.github/workflows/cgmanifest.json)./SPECS/LICENSES-AND-NOTICES/data/licenses.json,./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md,./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)*.signatures.jsonfilessudo make go-tidy-allandsudo make go-test-coveragepassSummary
This PR enables kernel configurations required for CRIU to run on mariner.
Change Log
CONFIG_CHECKPOINT_RESTORE,CONFIG_BINFMT_MISC,CONFIG_MEM_SOFT_DIRTY,CONFIG_PACKET_DIAG,CONFIG_UNIX_DIAG,CONFIG_INET_DIAG,CONFIG_INET_TCP_DIAG,CONFIG_INET_UDP_DIAG,CONFIG_NETFILTER_XT_MARK,CONFIG_STP,CONFIG_BRIDGE,CONFIG_LLC,CONFIG_NETLINK_DIAG,CONFIG_MACVLANandCONFIG_TUN.CONFIG_INET_SCTP_DIAGtom.CONFIG_INET_RAW_DIAGandCONFIG_INET_DIAG_DESTROYnot set.Does this affect the toolchain?
YES
Test Methodology
Locally built, installed on vm, and tested.