43.complex-dialog replaces a waterfall dialog incorrectly in all languages

[v-kydela]

Sample information

1. Sample type: samples
2. Sample language: dotnetcore/nodejs/python
3. Sample name: 43.complex-dialog

Describe the bug

Every sample uses "replace dialog" correctly except for sample 43 which erroneously replaces a waterfall dialog with the waterfall dialog's parent, a component dialog. Our samples should demonstrate that dialogs should only replace other dialogs that are meant to be on the same "level" which is to say in the same set/stack/context.

C#

return await stepContext.ReplaceDialogAsync(nameof(ReviewSelectionDialog), list, cancellationToken);

Node.js

return await stepContext.replaceDialog(REVIEW_SELECTION_DIALOG, list);

Python

return await step_context.replace_dialog(
    ReviewSelectionDialog.__name__, selected
)

There is no discernible faulty behavior when running the sample as-is, but the internal inconsistency in how the dialog stack is managed can cause problems if this sample is used as a starting point as this customer discovered.

Expected behavior

The waterfall dialog should replace itself either by using its ID directly or by referencing the component dialog's initial dialog ID.

[bug]