Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi-turn prompt asks if collected info is okay before summarizing the collected info #2018

Closed
JonathanFingold opened this issue Dec 4, 2019 · 2 comments · Fixed by #3957
Assignees
Labels

Comments

@JonathanFingold
Copy link
Contributor

Sample information

  1. Sample type: [\samples]
  2. Sample language: [dotnetcore, nodejs]
  3. Sample name: 5.multi-turn-prompt

Describe the bug

  1. The dialog asks the user whether the collected information is ok in the next to last step. Then summarizes the collected information in the last step. The order of these two steps should be reversed.
  2. A final acknowledgement step should be added, that tells the user that their information has been saved or discarded.

To Reproduce

Steps to reproduce the behavior:

  1. Run the sample.
  2. Error: complete the dialog and think about this from a usability perspective.

Expected behavior

Give a clear and concise description of what you expected to happen:

  • Summarize the information you wish the user to confirm before asking them to confirm it.

Additional context

The Python sample would also be affected. However, it is currently out of sync with the C# and JavaScript samples.

[bug]

@JonathanFingold
Copy link
Contributor Author

@tracyboehrer @mmiele - Do either of you want to weigh in on this issue?

@tracyboehrer
Copy link
Member

@JonathanFingold I would say it seems out of order in at least C# and Python. I didn't check JS, but I assume it is too. As far as demonstrating saving state in a multi-turn dialog it is successful. As a completely meaningful dialog flow... probably not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants