Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nodejs/typescript] App Insights samples missing bot properties #1361

Closed
daveta opened this issue Mar 28, 2019 · 4 comments
Closed

[nodejs/typescript] App Insights samples missing bot properties #1361

daveta opened this issue Mar 28, 2019 · 4 comments
Assignees
Labels
P0 Must Fix. Release-blocker P1 Painful if we don't fix, won't block releasing

Comments

@daveta
Copy link
Contributor

daveta commented Mar 28, 2019

Sample information

  1. Sample type: \samples\ and \solutions\
  2. Sample language: nodejs and typescript
  3. Sample name:
    21.luis-with-appinsights
    20.qna-with-appinsights
    Enterprise Template

Describe the bug

Not clear if something changed in restify, but any sample that uses Application Insights requires a small fix below:

// Create HTTP server
let server = restify.createServer();

// Enable the Application Insights middleware, which helps correlate all activity
// based on the incoming request.
server.use(restify.plugins.bodyParser());  // <== NEED THIS LINE
server.use(ApplicationInsightsWebserverMiddleware);

This enables the telemetry generated by Application Insights to use userId and sessionId that are bot specific (instead of web identifiers which don't make sense). It also adds some additional commonly used properties (ie, activityId, channelId, etc).

[bug]

@dmvtech dmvtech self-assigned this Mar 28, 2019
@benbrown
Copy link
Contributor

You should chat with @daveta because he also discovered this bug and may have fixed it elsewhere.

@CoHealer
Copy link

CoHealer commented Apr 1, 2019

Removing Support resources post reassignment

@cleemullins cleemullins added 4.5 P0 Must Fix. Release-blocker P1 Painful if we don't fix, won't block releasing labels May 24, 2019
@cleemullins
Copy link
Contributor

@Kaiqb "We believe this is fixed as the samples have been re-done".

@daveta daveta closed this as completed Jun 10, 2019
@daveta
Copy link
Contributor Author

daveta commented Jun 10, 2019

Samples now pass middleware to restify..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P0 Must Fix. Release-blocker P1 Painful if we don't fix, won't block releasing
Projects
None yet
Development

No branches or pull requests

6 participants