Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More consistent rp integration logging and rp configuration story #1558

Merged
merged 6 commits into from
Mar 17, 2021
Merged

More consistent rp integration logging and rp configuration story #1558

merged 6 commits into from
Mar 17, 2021

Conversation

trask
Copy link
Member

@trask trask commented Mar 15, 2021

  • Unifies app svc "user-logging" with regular "self diagnostics"
  • Rename "attach" to "rp integration"
  • Removes a couple of env vars that we aren't using
  • Sets default self diagnostic file path for Azure Functions on Linux to "/var/log/applicationinsights/" + DEFAULT_NAME
  • Do not read applicationinsights.json from agent directory for rp integrations because that makes it difficult to merge applicationinsights.json from RP and user json from APPLICATIONINSIGHTS_CONFIGURATION_CONTENT

@trask trask mentioned this pull request Mar 15, 2021
Merged
@trask trask merged commit 11400ac into master Mar 17, 2021
@trask trask deleted the trask/more-consistent-rp-logging branch March 17, 2021 00:38
@trask trask mentioned this pull request Mar 19, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heyams heyams heyams approved these changes

@kryalama kryalama Awaiting requested review from kryalama

@xiao-lix xiao-lix Awaiting requested review from xiao-lix

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@trask @heyams