uuid regression issue [multiple-value uuid.NewV4() in single-value context]

[XiaoliangHuang]

issue

the uuid has regression issue that uuid.NewV4() will return multiple results, but not a single id. so code like this will faile

	// Create operation ID if it does not exist
	if _, ok := envelope.Tags[contracts.OperationId]; !ok {
		envelope.Tags[contracts.OperationId] = uuid.NewV4().String()
	}

with error

multiple-value uuid.NewV4() in single-value context

similar issue has been reported many times in the uuid official site.

fix

can use fix like this

client.sessionID = uuid.NewV4().String()

u,_ := uuid.NewV4()
client.sessionID = u.String()

see mlabouardy/dialogflow-go-client@951d289

[jjjordanmsft]

This should be addressed by vendoring uuid to a specific version, which this SDK does via git submodules. The fix here would involve the change you suggest in tandem with updating the submodule version (though that could break people in the other direction if they have a funky setup).

[jjjordanmsft]

I don't think panic()'ing on uuid failures is a good idea for this SDK. However, I will log about them. Ideally, NewRequestTelemetry might return an error but that raises some API consistency issues that I'm not entirely thrilled with.

Somewhat related, I now have satori/go.uuid#73 on my radar, even though committing now won't put us in a worse situation than we were already in.