You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We should not set Unit in the Metadata since if it is set, it must be a suffix of the MetricFamily name separated by an underscore (see OpenMetrics spec).
This can be problematic since Micrometer adds the unit to the name but not necessarily as a suffix. For example, Micrometer does this test_seconds_max but if Unit is present the name should be test_max_seconds. The difference is not having the invalid unit definition on the output (# UNIT test_seconds_max seconds) which would cause scraping errors on the server side (the Prometheus 0.x registry also does this).
The text was updated successfully, but these errors were encountered:
We should not set
Unit
in theMetadata
since if it is set, it must be a suffix of the MetricFamily name separated by an underscore (see OpenMetrics spec).This can be problematic since Micrometer adds the unit to the name but not necessarily as a suffix. For example, Micrometer does this
test_seconds_max
but ifUnit
is present the name should betest_max_seconds
. The difference is not having the invalid unit definition on the output (# UNIT test_seconds_max seconds
) which would cause scraping errors on the server side (the Prometheus 0.x registry also does this).The text was updated successfully, but these errors were encountered: