-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Intermittent GC data size metrics with Shenandoah and ZGC #2872
Comments
Does downgrading micrometer or the JVM fix it? (Just to ensure that is the link) Does your chart 'null as zero' set or you are actually seeing zero? |
I'm actually seeing zero. It started on JDK 16 too. I don't tried to downgrade micrometer, the version I use is from spring boot's dependencies. I just can remember that on Spring Boot 2.4.x there where no drops to zero. |
I don't think Spring Boot has anything to do with this, my guess would be that Micrometer gets zero from JMX.
|
@jonatan-ivanov 👌 I'll do it on this week! |
Both the live and max size are controlled by an If you can provide a minimal sample project that we can run to see this behavior, it will help us investigate. |
@shakuzen I was able to reproduce it on Windows right in IDEA: VM Options to start application are |
How reliably are you able to reproduce that result? How long is the application running before you see it? I've tried running the application on my MacOS and Windows machine for about 30 minutes each and I don't see that. I'm seeing the value change but not with a 0 in between. |
@shakuzen Did you set Xmx to force GC working? Maybe you need tune allocation rate for your machine... On my PC it run for less than 1 minute until I saw zero. What is your JDK vendor? I'm using Bellsoft Liberica 17 Full JDK on Windows and bellsoft/liberica-openjdk-alpine-musl:17 for staging/production servers. |
I'm using the Liberica distribution of 17 on MacOS and Liberica's 17.0.1 downloaded via IntelliJ on Windows. I'm using the VM options you mentioned After trying some more, I was able to reproduce it. It's still not very easy for me to reproduce, which makes it time consuming to investigate. I think can see what the issue is now. We process I'll have to take a closer look tomorrow and write up tests, but it seems this probably doesn't happen in Micrometer 1.6.x and was introduced as a regression in 1.7.0 with #2560. |
fixed by #2875 |
@SimSonic if you could try out 1.7.7 or 1.8.1 and let us know if this is fixed for you, that'd be great. |
@shakuzen yes, can check in two days. |
@shakuzen Looking okay for about 4+ hours. This is a qa stage so have no production load. Keeping for a night. |
Confirms absence of zeroes for 17.5 hours. Thank you for your time! |
Thank you for letting us know about the issue and confirming the fix. |
I'm using Spring Boot (2.5.x) with Java 17 (Liberica JDK alpine-musl) and Shenandoan GC.
For a bunch of latest Spring Boot versions some GC's metrics are sometimes going to zero:
Previously (I don't remember exactly, but possibly on 2.4.x branch) — this graph was also continuous.
This is not case of failed prometheus scrapes, all other graphs are continuous.
It is looking weird now so I believe there is a bug somewhere.
Thanks.
The text was updated successfully, but these errors were encountered: