Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Question] Is it possible to change the color of the value label in v0.9.5? #210

Closed
slavko-m opened this issue Aug 10, 2020 · 13 comments · Fixed by #219
Closed

[Question] Is it possible to change the color of the value label in v0.9.5? #210

slavko-m opened this issue Aug 10, 2020 · 13 comments · Fixed by #219
Labels

Comments

@slavko-m
Copy link

According to some previous issues, I see that there was a ValueColor property of Entry, but now there is no such a property. There is a TextColor property , but it doesn't change the color of the value label - color of the label is always the same as the Color property of the ChartEntry.

@eman1986
Copy link
Member

The object got redone and that property got renamed to just Color. Not sure why that was renamed as I agree it's a little confusing.

@slavko-m
Copy link
Author

So it is not possible to have different color for value text and bar color (in a BarChart for example)? Color property will set both bar and text of the value to the same color.

@eman1986
Copy link
Member

No not currently. It makes sense they should match so you know what lines up to what

@slavko-m
Copy link
Author

OK, thanks for the info. It would be good to have that, because sometimes even if the color of the bar is visible, the text itself is not, like in the following example (green color). If I change the background to white, then the yellow text is not clearly visible. So, putting the text color in, for example, white, will be much better in this case.
Screenshot_20200810-224621

@eman1986
Copy link
Member

eman1986 commented Aug 10, 2020

I'm open to changing it so you can do that. You make a good point

@petro2050
Copy link

@eman1986 any update? I have the same issue. I need to show a yellow bar on a white background, but yellow text is not visible, so I'd like to use a different text color. The tight coupling between text color and bar color should be removed.

@eman1986
Copy link
Member

I haven't gotten to this yet, I do accept pull requests if someone wanted to work on this.

@petro2050
Copy link

@eman1986 submitted a PR. If it looks good, I'd love to see a new Nuget soon as this is a roadblock for me.

@eman1986
Copy link
Member

I pushed it in, I'll work on getting a nuget version up soon

@petro2050
Copy link

@eman1986 thanks!

@eman1986
Copy link
Member

I'm going to try getting this published this weekend, last couple days got away from me.

@eman1986
Copy link
Member

@petro2050 I have pushed up a new version with your PR changes.

@petro2050
Copy link

@eman1986 Thanks. Just pulled in the update and it's looking good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants