Fix USER_CUSTOM_PACKAGES_DIR #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pablogs9
approved these changes
Jun 16, 2022
|
@mergify backport main galactic humble |
🟠 Waiting for conditions to match
|
✅ Backports have been created
|
pablogs9
pushed a commit
that referenced
this pull request
Jun 16, 2022
* added microros_component/extra_packages support * added microros_component/extra_packages_support * copy only if usr pkgs exist * changes requested by @pablogs9 * Update library_generation.sh * Update library_generation.sh (cherry picked from commit 80b3417) Co-authored-by: Harsh Davda <[email protected]>
pablogs9
pushed a commit
that referenced
this pull request
Jun 16, 2022
* added microros_component/extra_packages support * added microros_component/extra_packages_support * copy only if usr pkgs exist * changes requested by @pablogs9 * Update library_generation.sh * Update library_generation.sh (cherry picked from commit 80b3417) Co-authored-by: Harsh Davda <[email protected]>
pablogs9
pushed a commit
that referenced
this pull request
Jun 16, 2022
* added microros_component/extra_packages support * added microros_component/extra_packages_support * copy only if usr pkgs exist * changes requested by @pablogs9 * Update library_generation.sh * Update library_generation.sh (cherry picked from commit 80b3417) Co-authored-by: Harsh Davda <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On the last pull request I hadnt realise that $MICROROS_LIBRARY_FOLDER is of depth 2. So need to go back twice to go from $BASE_PATH to $USER_CUSTOM_PACKAGES_DIR. after fixing this the build is able to pick packages from microros_component/extra_packages