Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate how to switch images between light and dark mode #1318

Closed
GCHQ-Developer-530 opened this issue Dec 11, 2024 · 1 comment
Closed

Investigate how to switch images between light and dark mode #1318

GCHQ-Developer-530 opened this issue Dec 11, 2024 · 1 comment
Assignees
@gd2910
Labels
spike This issue needs to be researched and explored before determining a course of action
Milestone
PI 10 V3

Comments

@GCHQ-Developer-530
Copy link
Contributor

Summary of the bug

Without loading them all in Gatsby, we need a way of loading the light and dark mode versions of images e.g. for the do don't caution images.

Perhaps using a package (gatsby image plugin?) to only load one lot of the images per theme mode.

We need to ensure performance isn't too negatively impacted by having double the amount of images.
@GCHQ-Developer-530 GCHQ-Developer-530 added the spike This issue needs to be researched and explored before determining a course of action label Dec 11, 2024
@MI6-255 MI6-255 added this to the PI 10 V3 milestone Dec 19, 2024
@gd2910
Copy link
Contributor

gd2910 commented Dec 19, 2024

Look into using picture HTML El
Image

@gd2910 gd2910 self-assigned this Jan 13, 2025
@gd2910 gd2910 transferred this issue from mi6/ic-ui-kit Jan 16, 2025
@gd2910 gd2910 mentioned this issue Jan 21, 2025
Draft
@gd2910 gd2910 moved this from Dev In Progress to In Review in Intelligence Community Design System Jan 22, 2025
@MI6-255 MI6-255 modified the milestones: PI 10 V3, PI 11 V3 Jan 28, 2025
@gd2910 gd2910 moved this from In Review to Done in Intelligence Community Design System Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gd2910 gd2910

Labels
spike This issue needs to be researched and explored before determining a course of action
Projects
Intelligence Community Design System
Status: Done
Milestone
PI 10 V3
Development

When branches are created from issues, their pull requests are automatically linked.

refs/heads/1318-investigate-how-to-switch-images-between-light-and-dark-mode mi6/ic-design-system
3 participants
@MI6-255 @GCHQ-Developer-530 @gd2910