Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Directory rules also match single files #45

Closed
PidgeyBE opened this issue Jun 22, 2023 · 0 comments · Fixed by #46
Closed

Directory rules also match single files #45

PidgeyBE opened this issue Jun 22, 2023 · 0 comments · Fixed by #46

Comments

@PidgeyBE
Copy link
Contributor

Hi

I noticed this issue:
If you have a rule:

build/

Then also files like build.py or build_something.py match this rule.
I think it's because trailing slashes (indicating directories) are stripped for some reason: https://github.com/mherrmann/gitignore_parser/blob/4dd7293/gitignore_parser.py#L89

I'm happy to open a PR!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix directory rule matching similar files PidgeyBE/gitignore_parser
1 participant
@PidgeyBE