Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release new gem version with "fix replace deprecated rpoplpush w/lmove" #795

Closed
mario-amazing opened this issue Jun 24, 2023 · 3 comments
Closed

Comments

@mario-amazing
Copy link

mario-amazing commented Jun 24, 2023

Could you add new release to rubygems with Fix replace deprecated rpoplpush w/lmove commit?

error:

sm_sidekiq | [sidekiq#5788] Redis has deprecated the `rpoplpush`command, called at ["/app/vendor/bundle/ruby/3.2.0/gems/sidekiq-unique-jobs-8.0.2/lib/sidekiq_unique_jobs/locksmith.rb:315:in `rpoplpush'"]

TMP solution:

gem 'sidekiq-unique-jobs', git: 'https://github.com/mhenrixon/sidekiq-unique-jobs', ref: 'b31e80b'
@Pallinder
Copy link

Please note that there are some pretty substantial changes in master that have not yet been released relating to locking mechanisms, doing the above will include these changes in your installed gem.

Forking and cherry picking the commit might be safer depending on what locking strategy you are utilizing..

@mario-amazing
Copy link
Author

How can I see, the commit with the new locking mechanism is a little bit upper then ref: 'b31e80b'
Screenshot 2023-07-06 at 20 12 18

@mhenrixon
Copy link
Owner

How can I see, the commit with the new locking mechanism is a little bit upper then ref: 'b31e80b'

https://github.com/mhenrixon/sidekiq-unique-jobs/releases/tag/v8.0.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants