Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sidekiq::Testing inline detection assumes you're always using inline testing #71

Closed
ajsharp opened this issue Jan 9, 2015 · 1 comment · Fixed by #75
Closed

Sidekiq::Testing inline detection assumes you're always using inline testing #71

ajsharp opened this issue Jan 9, 2015 · 1 comment · Fixed by #75

Comments

@ajsharp
Copy link

ajsharp commented Jan 9, 2015

The check in lib/sidekiq_unique_jobs/config.rb only looks if you're using sidekiq testing, not which method you're using. So, even if you're using sidekiq's fake testing method, sidekiq-unique-jobs still blows with the mock_redis gem. Is this gem necessary in all scenarios?

@Draiken
Copy link
Contributor

Draiken commented Jan 27, 2015

There is an inconsistency between the testing strategy and the testing connector. The strategy checks Sidekiq::Testing.inline? and the connector doesn't. This breaks a all my tests.

All specs on https://github.com/mhenrixon/sidekiq-unique-jobs/blob/master/spec/lib/sidekiq_testing_enabled_spec.rb are actually using MockRedis too.

I'll be sending a patch fixing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants