Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore dot import aliases in git push in import-alias-naming rule #937

Closed
denisvmedia opened this issue Nov 14, 2023 · 2 comments
Closed
Labels
rule proposal Issue proposing a new rule

Comments

@denisvmedia
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
Dot import aliases (import . "pkg/some") is a special feature in go. import-alias-naming rule was not meant to deal with special import aliases (thus it ignores _). Unfortunately, . import alias sneaked away from my focus.

Describe the solution you'd like
Ignore . alias in the code.

Describe alternatives you've considered
In golangci-lint it is possible to ignore this issue specifically, but it should be a part of revive as an easy and clean solution.

Additional context
I will provide a PR.

@denisvmedia
Copy link
Collaborator Author

cc @chavacava

@denisvmedia
Copy link
Collaborator Author

cc @mgechev

@denisvmedia denisvmedia added the rule proposal Issue proposing a new rule label Nov 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rule proposal Issue proposing a new rule
Projects
None yet
Development

No branches or pull requests

1 participant