Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

directive-selector-prefix rule clashes (sort of) with no-input-rename #138

Closed
karptonite opened this issue Nov 5, 2016 · 2 comments
Closed

Comments

@karptonite
Copy link

A common use case for an attribute directive is some sort of decoration, passing an input.

For example, you might have a selector, [prefixHighlightColor], and want to pass it as an input without the prefix, @Input('prefixHighlightColor') highlightColor: string;.

It seems that removing the prefix should not count as "renaming" for the no-input-rename rule. That rule seems sensible rule in any other case I can think of, so it would be a shame not to use it.

@mgechev
Copy link
Owner

mgechev commented Nov 28, 2016

@karptonite the issue makes sense. Probably we should move the discussion to https://github.com/angular/angular.io/issues. If you open an issue there, please mention me in order to be able to join the conversation.

@mgechev
Copy link
Owner

mgechev commented Nov 29, 2016

Just for completeness: the rules can be disabled by setting:

"no-input-rename": false,
"no-output-rename": false

in your tslint.json file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants