Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing Torsten test under cmdstan/stan/src/test/unit/parser #59

Closed
kyleam opened this issue Oct 24, 2024 · 2 comments
Closed

Failing Torsten test under cmdstan/stan/src/test/unit/parser #59

kyleam opened this issue Oct 24, 2024 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@kyleam
Copy link

kyleam commented Oct 24, 2024

Running the src/test/unit unit tests from the cmdstan/stan directory fails.
The only Torsten-specific file under cmdstan/stan/src/test/unit/ is parser/torsten_functions_test.cpp. It fails when running src/test/unit tests under cmdstan/stan/.

make -j15 test/test-models/good/mcmc/hmc/common/gauss.hpp test/test-models/good/mcmc/hmc/common/gauss3D.hpp test/test-models/good/mcmc/hmc/common/gauss3D.hpp test/test-models/good/mcmc/hmc/common/gauss3D.hpp test/test-models/good/mcmc/hmc/common/gauss3D.hpp test/test-models/good/mcmc/hmc/common/gauss3D.hpp test/test-models/good/mcmc/hmc/integrators/gauss.hpp test/test-models/good/mcmc/hmc/integrators/command.hpp test/test-models/good/mcmc/hmc/integrators/gauss.hpp test/test-models/good/mcmc/hmc/integrators/command.hpp test/test-models/good/mcmc/hmc/hamiltonians/funnel.hpp test/test-models/good/mcmc/hmc/hamiltonians/funnel.hpp
[... 114 lines ...]
g++ -std=c++1y -pthread -D_REENTRANT -Wno-sign-compare -Wno-ignored-attributes      -I lib/stan_math/lib/tbb_2020.3/include    -O3 -I src -I . -I lib/rapidjson_1.1.0/ -I lib/stan_math/ -I lib/stan_math/lib/eigen_3.4.0 -I lib/stan_math/lib/boost_1.78.0 -I lib/stan_math/lib/sundials_6.1.1/include -I lib/stan_math/lib/sundials_6.1.1/src/sundials -I lib/stan_math/lib/benchmark_1.5.1/googletest/googletest/include -I lib/stan_math/lib/benchmark_1.5.1/googletest/googletest -I lib/stan_math/lib/benchmark_1.5.1/googletest/googletest/include -I lib/stan_math/lib/benchmark_1.5.1/googletest/googletest -DBOOST_MPL_CFG_NO_PREPROCESSED_HEADERS -DBOOST_MPL_LIMIT_LIST_SIZE=30      -DBOOST_DISABLE_ASSERTS         -DGTEST_HAS_PTHREAD=0 -DGTEST_HAS_PTHREAD=0  -c src/test/unit/io/serializer_test.cpp -o test/unit/io/serializer_test.o
src/test/unit/parser/torsten_functions_test.cpp:2:10: fatal error: test/unit/lang/utility.hpp: No such file or directory
    2 | #include <test/unit/lang/utility.hpp>
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
make: *** [make/tests:63: test/unit/parser/torsten_functions_test.o] Error 1
make: *** Waiting for unfinished jobs....
[... 42 lines ...]
test/unit/optimization/bfgs_linesearch_test failed
exit now (09/06/24 14:54:34 EDT)
t/optimization/bfgs_test test/unit/optimization/bfgs_minimizer_test test/unit/optimization/lbfgs_update_test test/unit/optimization/bfgs_linesearch_test

The referenced file (test/unit/lang/utility.hpp) was renamed in stan-dev/stan's e7d7c210f (move lang tests out so they dont run, 2020-07-04) and then removed in 40a92dd37 (remove stanc2, 2021-01-27).

So it looks like this wasn't updated for the stanc3 transition. Perhaps it can just be removed entirely.

@kyleam kyleam added the bug Something isn't working label Oct 24, 2024
@yizhang-yiz
Copy link
Collaborator

The test is removed in #63.

@kyleam
Copy link
Author

kyleam commented Nov 14, 2024

Thanks @yizhang-yiz. Closing given gh-63 has been merged.

@kyleam kyleam closed this as completed Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants