fix: Auto start on download complete of online trace and some minor fixes

Author: pxor

src/frontend/index.nim

@@ -811,15 +811,16 @@ proc onUploadTraceFile(sender: js, response: UploadTraceArg) {.async.} =
     ]
   )
 
-proc onDownloadTraceFile(sender: js, response: jsobject(downloadId=seq[cstring])) {.async.} =
+proc onDownloadTraceFile(sender: js, response: jsobject(downloadKey=seq[cstring])) {.async.} =
   let res = await readProcessOutput(
     codetracerExe.cstring,
-    @[j"download"].concat(response.downloadId)
+    @[j"download"].concat(response.downloadKey)
   )
 
   if res.isOk:
-    await prepareForLoadingTrace(parseInt($res.v.trim()), nodeProcess.pid.to(int))
-    await loadExistingRecord(parseInt($res.v.trim()))
+    let traceId = parseInt($res.v.trim())
+    await prepareForLoadingTrace(traceId, nodeProcess.pid.to(int))
+    await loadExistingRecord(traceId)
 
 proc onSendBugReportAndLogs(sender: js, response: BugReportArg) {.async.} =
   let process = await runProcess(

src/frontend/ui/editor.nim

@@ -314,6 +314,7 @@ proc styleLines(self: EditorViewComponent, editor: MonacoEditor, lines: seq[Mona
     self.data.ui.welcomeScreen.loading = false
     self.data.ui.welcomeScreen.welcomeScreen = false
     self.data.ui.welcomeScreen.newRecordScreen = false
+    self.data.ui.welcomeScreen.openOnlineTrace = false
 
 proc lineActionClick(self: EditorViewComponent, tabInfo: TabInfo, line: js) =
   var element = line

src/frontend/ui/welcome_screen.nim

@@ -3,6 +3,8 @@ import
   ../../ct/version, 
   ui_imports, ../types
 
+const PROGRAM_NAME_LIMIT = 45
+
 proc uploadTrace(self: WelcomeScreenComponent, trace: Trace) =
   self.data.ipc.send "CODETRACER::upload-trace-file",
     UploadTraceArg(
@@ -21,7 +23,7 @@ proc recentProjectView(self: WelcomeScreenComponent, trace: Trace): VNode =
         self.data.ipc.send "CODETRACER::load-recent-trace", js{ traceId: trace.id }
     )
   ):
-    let programLimitName = 45 
+    let programLimitName = PROGRAM_NAME_LIMIT 
     let limitedProgramName = if trace.program.len > programLimitName:
         ".." & ($trace.program)[^programLimitName..^1]
       else:
@@ -255,7 +257,7 @@ proc onlineFormView(self: WelcomeScreenComponent): VNode =
           #     cast[JsObject](self.newRecord.workDir)
           self.data.ipc.send(
               "CODETRACER::download-trace-file", js{
-                downloadId: concat(self.newDownload.args),
+                downloadKey: concat(self.newDownload.args),
               }
           )
       ):