Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

find bugs in langgraph-rag-agent.ipynb #571

Closed
1 of 2 tasks
jarvisDang opened this issue Jun 24, 2024 · 2 comments
Closed
1 of 2 tasks

find bugs in langgraph-rag-agent.ipynb #571

jarvisDang opened this issue Jun 24, 2024 · 2 comments
Assignees

Comments

@jarvisDang
Copy link

System Info

no gpu needed, common cpu can run this jupter note

Information

  • The official example scripts
  • My own modified scripts

🐛 Describe the bug

bug1: function format_docs is declared but never used, it should be used to convert Document to String
bug2: in class GraphState, documents : List[str] should be declared as documents : List[Document]
I submit a pull request to solve these 2 bugs , plz refer to my pull request and pass it: #570

Error logs

no comiling error log

Expected behavior

no comiling error log, just code correction

@wukaixingxp
Copy link
Contributor

@jeffxtang Can you take a look at this issue and the PR 570. Thanks!

@jeffxtang
Copy link
Contributor

Thanks @jarvisDang @wukaixingxp PR looks good and merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants