Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hovering doesn’t take quotes into account #1

Closed
meraymond2 opened this issue Jul 8, 2020 · 2 comments · Fixed by #7
Closed

Hovering doesn’t take quotes into account #1

meraymond2 opened this issue Jul 8, 2020 · 2 comments · Fixed by #7
Assignees

Comments

@meraymond2
Copy link
Owner

The identifier regex doesn’t include double quotes, so if you hover over a string literal, it will try to get the type of the contents, not the string itself.

@meraymond2 meraymond2 self-assigned this Jul 8, 2020
@meraymond2
Copy link
Owner Author

Unfortunately, this is more complicated than I had hoped. I could probably make this work for strings without spaces, but not with. Then I'd have issues with multi-line strings. The official advice appears to be to re-parse the entire document if you need to know the type of any particular position, you can't just hijack the text-mate scopes.

@meraymond2
Copy link
Owner Author

I have a naïve but effective fix for this, leaving this comment as a reminder to myself to merge it this weekend.

@meraymond2 meraymond2 mentioned this issue Oct 22, 2020
@meraymond2 meraymond2 mentioned this issue Dec 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant