Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(templates): Update Cookiecutter templates #2847

Merged
merged 2 commits into from
Jan 29, 2025

Conversation

edgarrmondragon
Copy link
Collaborator

@edgarrmondragon edgarrmondragon commented Jan 29, 2025

Summary by Sourcery

Update Cookiecutter templates to remove unnecessary quotes in PyPI URLs and update Ruff to v0.9.3.

Build:

  • Remove quotes from PyPI URLs in build workflows.

CI:

  • Update Ruff pre-commit hook to v0.9.3.

📚 Documentation preview 📚: https://meltano-sdk--2847.org.readthedocs.build/en/2847/

Copy link
Contributor

sourcery-ai bot commented Jan 29, 2025

Reviewer's Guide by Sourcery

This pull request updates the cookiecutter templates to fix a bug in the PyPI URL and to update the ruff pre-commit hook to the latest version.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Fixed the PyPI URL in the build workflow files.
  • Removed the quotes around the project name in the PyPI URL.
cookiecutter/mapper-template/{{cookiecutter.mapper_id}}/.github/workflows/build.yml
cookiecutter/tap-template/{{cookiecutter.tap_id}}/.github/workflows/build.yml
cookiecutter/target-template/{{cookiecutter.target_id}}/.github/workflows/build.yml
Updated the ruff pre-commit hook to the latest version.
  • Updated the ruff pre-commit hook revision from v0.9.2 to v0.9.3.
cookiecutter/mapper-template/{{cookiecutter.mapper_id}}/.pre-commit-config.yaml
cookiecutter/tap-template/{{cookiecutter.tap_id}}/.pre-commit-config.yaml
cookiecutter/target-template/{{cookiecutter.target_id}}/.pre-commit-config.yaml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@edgarrmondragon edgarrmondragon self-assigned this Jan 29, 2025
@edgarrmondragon edgarrmondragon marked this pull request as ready for review January 29, 2025 23:07
@edgarrmondragon edgarrmondragon merged commit 963abf7 into main Jan 29, 2025
9 checks passed
@edgarrmondragon edgarrmondragon deleted the edgarrmondragon/fix/update-templates branch January 29, 2025 23:11
@edgarrmondragon edgarrmondragon added the Cookiecutter Tap, target and mapper templates label Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Cookiecutter Tap, target and mapper templates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant