Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(taps): Respect forced replication method when retrieving state #2107

Conversation

edgarrmondragon
Copy link
Collaborator

@edgarrmondragon edgarrmondragon commented Dec 16, 2023

Copy link

codspeed-hq bot commented Dec 16, 2023

CodSpeed Performance Report

Merging #2107 will not alter performance

Comparing 2067-feat-make-streamget_starting_-methods-return-none-for-full-table-replication-streams (5e65139) with main (ae5b125)

Summary

✅ 6 untouched benchmarks

Copy link

codecov bot commented Dec 16, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ae5b125) 87.72% compared to head (5e65139) 87.76%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2107      +/-   ##
==========================================
+ Coverage   87.72%   87.76%   +0.04%     
==========================================
  Files          60       60              
  Lines        4946     4946              
  Branches     1007     1007              
==========================================
+ Hits         4339     4341       +2     
+ Misses        425      424       -1     
+ Partials      182      181       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edgarrmondragon edgarrmondragon force-pushed the 2067-feat-make-streamget_starting_-methods-return-none-for-full-table-replication-streams branch from 43e1769 to fece2c8 Compare December 16, 2023 00:18
@edgarrmondragon edgarrmondragon force-pushed the 2067-feat-make-streamget_starting_-methods-return-none-for-full-table-replication-streams branch from fece2c8 to 5e65139 Compare December 17, 2023 18:27
@edgarrmondragon edgarrmondragon marked this pull request as ready for review December 17, 2023 18:32
@edgarrmondragon edgarrmondragon requested review from a team and kgpayne as code owners December 17, 2023 18:32
@edgarrmondragon edgarrmondragon merged commit 71a7785 into main Dec 17, 2023
30 checks passed
@edgarrmondragon edgarrmondragon deleted the 2067-feat-make-streamget_starting_-methods-return-none-for-full-table-replication-streams branch December 17, 2023 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: Make Stream.get_starting_*() methods return None for full-table replication streams
1 participant