Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(templates): Migrate shell scripts for cookiecutter e2e tests to Nox #1563

Merged
merged 11 commits into from
Mar 31, 2023

Conversation

mkranna
Copy link
Contributor

@mkranna mkranna commented Mar 30, 2023

Closes #1423: Migrate shell scripts for cookiecutter e2e tests to Nox.

  • First, I added a new parametrised session test_cookiecutter to the main project noxfile.py, which replaces the test_cookiercutter.sh (parametrised by the json-files in e2e-tests/cookiecutter folder). To run all cookiecutter replay files, use the following terminal command: nox --session=test_cookiecutter.

  • Second, I updated the cookiecutter-e2e.yml to simply call the nox session as above. It is no longer required to maintain a list of the replay files in that YML.

  • Comment: the advantage of the current cookiecutter-e2e.yml is that is it no longer lists replay files, but on the other hand the tests takes longer since they are not run in parallel. Alternatively, I can call tests in parallel as it was done before.


📚 Documentation preview 📚: https://meltano-sdk--1563.org.readthedocs.build/en/1563/

@codecov
Copy link

codecov bot commented Mar 30, 2023

Codecov Report

Merging #1563 (de6d6ee) into main (a5a94d7) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1563   +/-   ##
=======================================
  Coverage   85.59%   85.59%           
=======================================
  Files          57       57           
  Lines        4726     4726           
  Branches      807      807           
=======================================
  Hits         4045     4045           
  Misses        488      488           
  Partials      193      193           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@tayloramurphy
Copy link
Collaborator

Thanks for the contribution @mkranna ! One of our engineers will take a look at it soon.

@edgarrmondragon edgarrmondragon self-assigned this Mar 30, 2023
noxfile.py Outdated Show resolved Hide resolved
noxfile.py Outdated Show resolved Hide resolved
@edgarrmondragon edgarrmondragon changed the title feat: Migrate shell scripts for cookiecutter e2e tests to Nox. ci: Migrate shell scripts for cookiecutter e2e tests to Nox. Mar 30, 2023
@edgarrmondragon edgarrmondragon changed the title ci: Migrate shell scripts for cookiecutter e2e tests to Nox. ci: Migrate shell scripts for cookiecutter e2e tests to Nox Mar 30, 2023
@edgarrmondragon edgarrmondragon changed the title ci: Migrate shell scripts for cookiecutter e2e tests to Nox feat(templates): Migrate shell scripts for cookiecutter e2e tests to Nox Mar 31, 2023
Copy link
Collaborator

@edgarrmondragon edgarrmondragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great!

Screenshot 2023-03-31 at 11 26 54

Thanks @mkranna!

@edgarrmondragon edgarrmondragon merged commit 304d123 into meltano:main Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Migrate shell scripts for cookiecutter e2e tests to Nox
3 participants