-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(templates): Migrate shell scripts for cookiecutter e2e tests to Nox #1563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkranna
requested review from
edgarrmondragon,
a team,
cjohnhanson and
aaronsteers
as code owners
March 30, 2023 13:23
Codecov Report
@@ Coverage Diff @@
## main #1563 +/- ##
=======================================
Coverage 85.59% 85.59%
=======================================
Files 57 57
Lines 4726 4726
Branches 807 807
=======================================
Hits 4045 4045
Misses 488 488
Partials 193 193 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Thanks for the contribution @mkranna ! One of our engineers will take a look at it soon. |
edgarrmondragon
changed the title
feat: Migrate shell scripts for cookiecutter e2e tests to Nox.
ci: Migrate shell scripts for cookiecutter e2e tests to Nox.
Mar 30, 2023
edgarrmondragon
changed the title
ci: Migrate shell scripts for cookiecutter e2e tests to Nox.
ci: Migrate shell scripts for cookiecutter e2e tests to Nox
Mar 30, 2023
edgarrmondragon
changed the title
ci: Migrate shell scripts for cookiecutter e2e tests to Nox
feat(templates): Migrate shell scripts for cookiecutter e2e tests to Nox
Mar 31, 2023
edgarrmondragon
approved these changes
Mar 31, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1423: Migrate shell scripts for cookiecutter e2e tests to Nox.
First, I added a new parametrised session
test_cookiecutter
to the main projectnoxfile.py
, which replaces thetest_cookiercutter.sh
(parametrised by the json-files in e2e-tests/cookiecutter folder). To run all cookiecutter replay files, use the following terminal command:nox --session=test_cookiecutter
.Second, I updated the
cookiecutter-e2e.yml
to simply call the nox session as above. It is no longer required to maintain a list of the replay files in that YML.Comment: the advantage of the current
cookiecutter-e2e.yml
is that is it no longer lists replay files, but on the other hand the tests takes longer since they are not run in parallel. Alternatively, I can call tests in parallel as it was done before.📚 Documentation preview 📚: https://meltano-sdk--1563.org.readthedocs.build/en/1563/