-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(mappers): Schema passthrough for whitelisted fields #1219
fix(mappers): Schema passthrough for whitelisted fields #1219
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1219 +/- ##
==========================================
+ Coverage 83.68% 83.72% +0.04%
==========================================
Files 42 42
Lines 3910 3909 -1
Branches 666 665 -1
==========================================
+ Hits 3272 3273 +1
Misses 473 473
+ Partials 165 163 -2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
edbdb95
to
b34f509
Compare
@edgarrmondragon - This is great. I like this approach a lot, but the library is new to me and I'm not sure if I would know where to look to confirm the changes. So, if we fix the double-state messages at the end of each sync (for example), I expect the job would fail. And I think (?) then the proper course for developer would then be to run a snapshot update, then confirm the git diff of those snapshots that got updated, and if the new schema files are better or at least as good, then those could be merged back to main. Could we add something in Thanks! |
@aaronsteers I've updated the contributing page with more details: af1ef39, https://meltano-sdk--1219.org.readthedocs.build/en/1219/CONTRIBUTING.html#snapshot-testing |
Related:
We'll have to release a new version of the SDK, and bump it in MeltanoLabs/meltano-map-transform.
I changed the
test_mapped_stream
to use snapshots so we can validate the entire tap output.📚 Documentation preview 📚: https://meltano-sdk--1219.org.readthedocs.build/en/1219/