Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(tf2-competitive): use ARG to specify all the URLs #30

Merged
merged 1 commit into from
Jan 18, 2022
Merged

feat(tf2-competitive): use ARG to specify all the URLs #30

merged 1 commit into from
Jan 18, 2022

Conversation

garrappachc
Copy link
Member

No description provided.

@garrappachc garrappachc added the enhancement New feature or request label Jan 18, 2022
c43721
c43721 approved these changes Jan 18, 2022
View reviewed changes
Copy link

@c43721 c43721 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Doing this in bash may make more sense, but I see no issue with keeping everything in ARGS.

@garrappachc garrappachc merged commit be55ca4 into master Jan 18, 2022
@garrappachc garrappachc deleted the use-arg-to-specify-urls branch January 18, 2022 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c43721 c43721 c43721 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@garrappachc @c43721