Skip to content
This repository has been archived by the owner on Dec 23, 2018. It is now read-only.

WebExtensions? #47

Closed
ntninja opened this issue Jan 7, 2017 · 1 comment
Closed

WebExtensions? #47

ntninja opened this issue Jan 7, 2017 · 1 comment

Comments

@ntninja
Copy link
Collaborator

ntninja commented Jan 7, 2017

Unless I'm mistaken the only really important non-GUI browser API we need would be webRequest.onBeforeSendHeaders and that should be easy to integrate with. Everything else should be copy-paste from the current code base.

The only major porting pain-point are the settings:

Stored data is a problem for people trying to migrate from legacy add-on types, because the legacy add-ons can't use the WebExtension storage APIs, while WebExtensions can't use the legacy storage APIs. For example, if an SDK add-on uses the SDK's simple-prefs API to store preferences, the WebExtension version won't be able to access that data. (source)

The official workaround is to use the not-yet-released Embedded WebExtensions support, as a transition utility – not particularly appealing as requires the migration to be split into a least two steps and adds a lot of extra work and possible ways to fuck it up. Maybe it's not even worth it at all in this case?

Any thoughts on this topic?

@ntninja
Copy link
Collaborator Author

ntninja commented Apr 17, 2017

Fixed by #48

@ntninja ntninja closed this as completed Apr 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant