Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FaaSController #59

Merged
merged 23 commits into from
Jun 26, 2021
Merged

FaaSController #59

merged 23 commits into from
Jun 26, 2021

Conversation

benja-wu
Copy link
Contributor

@benja-wu benja-wu commented Jun 22, 2021 •
edited
Loading

Close #22

  • Introducing FaaSController to Easegress.
  • Adding its user manual.
  • APIs had been tested in the FaaS cluster with K8s + Knative serving.

@benja-wu benja-wu added the enhancement New feature or request label Jun 22, 2021
@benja-wu benja-wu added this to the v1.0.1 milestone Jun 22, 2021
@benja-wu benja-wu requested review from localvar and xxx7xxxx June 22, 2021 09:10
localvar
localvar reviewed Jun 23, 2021
View reviewed changes
localvar
localvar reviewed Jun 24, 2021
View reviewed changes
benjaminwu and others added 16 commits June 24, 2021 12:20
xxx7xxxx
xxx7xxxx reviewed Jun 25, 2021
View reviewed changes
haoel
haoel suggested changes Jun 25, 2021
View reviewed changes
@benja-wu
Copy link
Contributor Author

The FSM correcting and code cleaning has been updated.

haoel
haoel reviewed Jun 26, 2021
View reviewed changes
xxx7xxxx
xxx7xxxx reviewed Jun 26, 2021
View reviewed changes
pkg/object/function/storage/storage.go

type (
// Storage is the interface to contain storage APIs.
Storage interface {
Copy link
Contributor

@xxx7xxxx xxx7xxxx Jun 26, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't see the reason why introduce the Storage.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This Storage interface is introduced for keeping the controller implementation consistent with Mesh Controller.
https://github.com/megaease/easegress/blob/main/pkg/object/meshcontroller/storage/storage.go

@xxx7xxxx xxx7xxxx merged commit d6af0dc into easegress-io:main Jun 26, 2021
@tg123 tg123 mentioned this pull request Jun 27, 2021
Closed
@benja-wu benja-wu deleted the function branch June 29, 2021 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@localvar localvar localvar approved these changes

@haoel haoel haoel approved these changes

@xxx7xxxx xxx7xxxx xxx7xxxx approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
v1.0.1
Development

Successfully merging this pull request may close these issues.

[feature] FaaSController
4 participants
@benja-wu @localvar @haoel @xxx7xxxx