Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proxy to send zipkin b3 headers #579

Merged

Conversation

samutamm
Copy link
Contributor

@samutamm samutamm commented Apr 11, 2022

Fix #578

  • opentracing is deprecated (in favor of open-telemetry) so remove it and use "native" zipkin for tracing
  • call zipkin-go SDK and remove explicit creation of spans and span.Finish()
  • When tracing object is configured in HTTPServer, share the created tracer instance to Proxy filter via HTTPContext.
  • Use zipkin to inject B3 headers if not present already

@samutamm samutamm requested review from xxx7xxxx and removed request for xxx7xxxx April 11, 2022 08:44
@codecov-commenter
Copy link

codecov-commenter commented Apr 11, 2022

Codecov Report

Merging #579 (a844049) into main (cdc0780) will increase coverage by 0.01%.
The diff coverage is 97.22%.

@@            Coverage Diff             @@
##             main     #579      +/-   ##
==========================================
+ Coverage   80.10%   80.12%   +0.01%     
==========================================
  Files          95       95              
  Lines       10940    10956      +16     
==========================================
+ Hits         8764     8779      +15     
- Misses       1700     1701       +1     
  Partials      476      476              
Impacted Files Coverage Δ
pkg/object/httpserver/mux.go 71.70% <ø> (-0.16%) ⬇️
pkg/filter/proxy/proxy.go 82.40% <96.55%> (+2.30%) ⬆️
pkg/filter/proxy/pool.go 79.78% <100.00%> (-0.22%) ⬇️
pkg/object/httpserver/spec.go 73.33% <0.00%> (-4.00%) ⬇️
pkg/object/mqttproxy/client.go 79.63% <0.00%> (-0.91%) ⬇️
pkg/filter/proxy/request.go 100.00% <0.00%> (+4.54%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cdc0780...a844049. Read the comment docs.

@samutamm samutamm requested review from xxx7xxxx, localvar and suchen-sci and removed request for xxx7xxxx April 12, 2022 01:06
@samutamm samutamm marked this pull request as ready for review April 12, 2022 02:03
@samutamm samutamm requested a review from localvar April 13, 2022 05:45
@samutamm samutamm requested a review from localvar April 15, 2022 05:09
@samutamm samutamm requested a review from localvar April 15, 2022 08:22
@samutamm samutamm merged commit 781362b into easegress-io:main Apr 18, 2022
@samutamm samutamm deleted the httproxy-openzipkin-be-propagation branch April 18, 2022 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proxy filter to propagate Openzipkin b3 headers
4 participants