Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make syncer interface, add mocked syncer and watcher #507

Merged
merged 2 commits into from
Feb 11, 2022
Merged

make syncer interface, add mocked syncer and watcher #507

merged 2 commits into from
Feb 11, 2022

Conversation

suchen-sci
Copy link
Contributor

No description provided.

@suchen-sci suchen-sci requested review from localvar and samutamm and removed request for localvar February 11, 2022 09:26
@codecov-commenter
Copy link

codecov-commenter commented Feb 11, 2022

Codecov Report

Merging #507 (e880365) into main (e2a96b8) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #507      +/-   ##
==========================================
+ Coverage   80.52%   80.56%   +0.03%     
==========================================
  Files          87       87              
  Lines       10123    10123              
==========================================
+ Hits         8152     8156       +4     
+ Misses       1516     1514       -2     
+ Partials      455      453       -2     
Impacted Files Coverage Δ
pkg/cluster/cluster_interface.go 76.92% <ø> (ø)
pkg/cluster/syncer.go 77.56% <100.00%> (ø)
pkg/filter/headerlookup/headerlookup.go 88.81% <100.00%> (ø)
pkg/filter/validator/basicauth.go 78.89% <100.00%> (ø)
pkg/object/autocertmanager/storage.go 64.84% <100.00%> (ø)
pkg/object/mqttproxy/client.go 79.63% <0.00%> (-0.91%) ⬇️
pkg/cluster/cluster.go 52.89% <0.00%> (+1.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e2a96b8...e880365. Read the comment docs.

@samutamm samutamm merged commit a9c9167 into easegress-io:main Feb 11, 2022
@suchen-sci suchen-sci deleted the update-syncer branch February 11, 2022 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants