Corsadaptor support origin #498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: hanjuntao <[email protected]>
Co-authored-by: hanjuntao <[email protected]>
localvar
approved these changes
Feb 8, 2022
suchen-sci
approved these changes
Feb 10, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #483 and #484
As described in issue #483, currently CORSAdaptor support only CORS pre-flight requests. It does not help in enabling CORS for common usecase, where frontend and backend of an application have different origins. This testcase illustrates it in detail.
This PR adds new parameter
supportCORSRequest. When true, CORSAdaptor handles both CORS pre-flight and CORS requests and supports the testcase above. When false, by default, the current logic is used.Reference: https://fetch.spec.whatwg.org/#http-requests
Thanks @jthann for the testcase and PR #484, I included the proposed changes in this PR.