Fix docs and add contributing guide #475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
samutamm
commented
Jan 24, 2022
samutamm
commented
- Fix typo in docs
- Add CONTRIBUTING.md guide
Co-authored-by: SU Chen <[email protected]> Co-authored-by: Bomin Zhang <[email protected]> Co-authored-by: Yun Long <[email protected]>
samutamm
requested review from
localvar,
xxx7xxxx,
zhao-kun,
suchen-sci and
haoel
localvar
reviewed
Jan 25, 2022
Co-authored-by: Bomin Zhang <[email protected]>
suchen-sci
reviewed
Jan 25, 2022
haoel
approved these changes
Jan 25, 2022
Co-authored-by: SU Chen <[email protected]> Co-authored-by: Hao Chen <[email protected]>
There's already link to README.md part that contains the Slack link. I think it's better to have the link in one place so it's easier to keep up-to-date |
suchen-sci
approved these changes
Jan 25, 2022
localvar
approved these changes
Jan 25, 2022
samutamm
pushed a commit
to samutamm/easegress
that referenced
this pull request
Jan 27, 2022
* fix typo and add example for requestAdaptor.Path * Add contributing guide Co-authored-by: SU Chen <[email protected]> Co-authored-by: Bomin Zhang <[email protected]> Co-authored-by: Yun Long <[email protected]> * Update CONTRIBUTING.md Co-authored-by: Bomin Zhang <[email protected]> * fix typo and add link to contributing.md to README.md Co-authored-by: SU Chen <[email protected]> Co-authored-by: Hao Chen <[email protected]> Co-authored-by: SU Chen <[email protected]> Co-authored-by: Bomin Zhang <[email protected]> Co-authored-by: Yun Long <[email protected]> Co-authored-by: Bomin Zhang <[email protected]> Co-authored-by: Hao Chen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.