Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add kafka backend and header to json filter to http pipeline #458

Merged
merged 19 commits into from
Jan 14, 2022
Merged

add kafka backend and header to json filter to http pipeline #458

merged 19 commits into from
Jan 14, 2022

Conversation

suchen-sci
Copy link
Contributor

@suchen-sci suchen-sci commented Jan 11, 2022

Json encode decode benchmark:

github.com/goccy/go-json: 12628 ns/op
std lib json: 22767 ns/op
github.com/json-iterator/go: 15210 ns/op

Copy link
Contributor

@samutamm samutamm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Github analysis (revive) action identified few naming issues, please fix them.

@codecov-commenter
Copy link

codecov-commenter commented Jan 12, 2022

Codecov Report

Merging #458 (51171b7) into main (31315af) will decrease coverage by 0.17%.
The diff coverage is 71.34%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #458      +/-   ##
==========================================
- Coverage   80.07%   79.90%   -0.18%     
==========================================
  Files          76       80       +4     
  Lines        8708     8886     +178     
==========================================
+ Hits         6973     7100     +127     
- Misses       1336     1374      +38     
- Partials      399      412      +13     
Impacted Files Coverage Δ
pkg/object/httppipeline/mock.go 0.00% <0.00%> (ø)
pkg/filter/headertojson/spec.go 68.96% <68.96%> (ø)
pkg/filter/headertojson/headertojson.go 74.62% <74.62%> (ø)
pkg/filter/kafkabackend/kafka.go 77.02% <77.02%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31315af...51171b7. Read the comment docs.

@localvar localvar mentioned this pull request Jan 13, 2022
@suchen-sci suchen-sci merged commit 519b6bb into easegress-io:main Jan 14, 2022
@suchen-sci suchen-sci deleted the megacloud-kafka branch January 14, 2022 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants