-
Notifications
You must be signed in to change notification settings - Fork 505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add pipeline route for mqttproxy #453
add pipeline route for mqttproxy #453
Conversation
Codecov Report
@@ Coverage Diff @@
## main #453 +/- ##
==========================================
- Coverage 80.57% 80.52% -0.06%
==========================================
Files 70 74 +4
Lines 8171 8353 +182
==========================================
+ Hits 6584 6726 +142
- Misses 1230 1261 +31
- Partials 357 366 +9
Continue to review full report at Codecov.
|
Suggest change YAML formation to: rules:
- when:
packetType: Publish
pipleline: publish-pipeline For now, we just support the substitute keyword |
updated! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, look good to me, except for decoupling the Kafka plugin
I have some jobs that were suspended for the PR. @localvar please help review the PR and push forward the progress of the merging when you are free |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This pr add
Pipeline
route forMQTTProxy
and also make backendKafka
a MQTT filter.New version yaml:
Now MQTTProxy can route MQTT packets to different pipelines based on the packet type. Currently support:
Connect
,Disconnect
,Publish
,Subscribe
,Unsubscribe
.