support pem in both base64 and plain text #425
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
certs in HTTP server spec were in plain text before but were updated to base64 encoding in #391 , this PR auto-detect the encoding, and the certs could be in either plain text or base64.
the PR also fix two issues in the AutoCertManager:
autocertmanager.GetCertificate
should return a nil error.autocertmanager.GetCertificate
should return a nil error for that domain.