Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support pem in both base64 and plain text #425

Merged
merged 3 commits into from
Dec 22, 2021
Merged

support pem in both base64 and plain text #425

merged 3 commits into from
Dec 22, 2021

Conversation

localvar
Copy link
Collaborator

@localvar localvar commented Dec 22, 2021

certs in HTTP server spec were in plain text before but were updated to base64 encoding in #391 , this PR auto-detect the encoding, and the certs could be in either plain text or base64.

the PR also fix two issues in the AutoCertManager:

  • When AutoCertManager is not started, autocertmanager.GetCertificate should return a nil error.
  • If a domain is not managed by the AutoCertManager, autocertmanager.GetCertificate should return a nil error for that domain.

@codecov-commenter
Copy link

codecov-commenter commented Dec 22, 2021

Codecov Report

Merging #425 (ec85066) into main (554efe7) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #425   +/-   ##
=======================================
  Coverage   80.43%   80.43%           
=======================================
  Files          70       70           
  Lines        8093     8093           
=======================================
  Hits         6510     6510           
  Misses       1223     1223           
  Partials      360      360           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 758c860...ec85066. Read the comment docs.

@localvar localvar marked this pull request as draft December 22, 2021 04:27
@localvar localvar marked this pull request as ready for review December 22, 2021 05:23
@samutamm samutamm merged commit 2f44830 into easegress-io:main Dec 22, 2021
@localvar localvar deleted the decode-pem branch December 22, 2021 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants