change the logger level, fix #296 #307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
megaeasex
approved these changes
Oct 18, 2021
Codecov Report
@@ Coverage Diff @@
## main #307 +/- ##
==========================================
- Coverage 80.32% 80.28% -0.05%
==========================================
Files 53 53
Lines 5926 5929 +3
==========================================
Hits 4760 4760
- Misses 906 909 +3
Partials 260 260
Continue to review full report at Codecov.
|
xxx7xxxx
reviewed
Oct 18, 2021
pkg/filter/proxy/server.go
Outdated
| @@ -135,8 +135,11 @@ func (s *servers) handleEvent(event *serviceregistry.ServiceEvent) { | |||
| func (s *servers) tryUseService() { | |||
| serviceInstanceSpecs, err := s.serviceRegistry.ListServiceInstances(s.poolSpec.ServiceRegistry, s.poolSpec.ServiceName) | |||
|
|
|||
| logger.Warnf("successfully use service %s/%s", | |||
There was a problem hiding this comment.
The level should be Info.
There was a problem hiding this comment.
And it is not good to put the message here: this is a success message, but it may log a warning later in useService.
There was a problem hiding this comment.
Oh, this message is not supposed to be committed. 🤔
pkg/filter/proxy/server.go
Outdated
| if err != nil { | ||
| logger.Errorf("get service %s/%s failed: %v", | ||
| logger.Warnf("first try to use service %s/%s failed: %v, will try again when it's created", |
There was a problem hiding this comment.
Suggested change
| logger.Warnf("first try to use service %s/%s failed: %v, will try again when it's created", | |
| logger.Warnf("try to use service %s/%s failed(will try again): %v", |
megaeasex
approved these changes
Oct 18, 2021
localvar
approved these changes
Oct 19, 2021
xxx7xxxx
approved these changes
Oct 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check #296 for more details.