Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoid send duplicated metrics data (close #215) #217

Merged
merged 2 commits into from
Aug 31, 2021
Merged

avoid send duplicated metrics data (close #215) #217

merged 2 commits into from
Aug 31, 2021

Conversation

localvar
Copy link
Collaborator

also fix several other minor issues.

also fix several other minor issues.
@localvar localvar requested review from xxx7xxxx and benja-wu August 31, 2021 07:31
Copy link

@megaeasex megaeasex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[TASK:easegress-pr-test SUCCESS]megaease/easegress Pull Request 217 Deploy Test Success

@codecov-commenter
Copy link

codecov-commenter commented Aug 31, 2021

Codecov Report

Merging #217 (a813d70) into main (7e2fb5b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #217   +/-   ##
=======================================
  Coverage   80.14%   80.14%           
=======================================
  Files          44       44           
  Lines        4826     4826           
=======================================
  Hits         3868     3868           
  Misses        738      738           
  Partials      220      220           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e2fb5b...a813d70. Read the comment docs.

Copy link

@megaeasex megaeasex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[TASK:easegress-pr-test SUCCESS]megaease/easegress Pull Request 217 Deploy Test Success

Copy link
Contributor

@benja-wu benja-wu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@benja-wu benja-wu added the bug Something isn't working label Aug 31, 2021
@benja-wu benja-wu linked an issue Aug 31, 2021 that may be closed by this pull request
@benja-wu benja-wu added this to the v1.3.0 milestone Aug 31, 2021
@benja-wu benja-wu linked an issue Aug 31, 2021 that may be closed by this pull request
@benja-wu benja-wu merged commit f209820 into easegress-io:main Aug 31, 2021
@localvar localvar deleted the issue-215 branch August 31, 2021 08:46
xmh19936688 pushed a commit to xmh19936688/easegress that referenced this pull request Sep 13, 2021
…s-io#217)

* avoid send duplicated metrics data (close easegress-io#215)

also fix several other minor issues.

* Update pkg/util/timetool/distributedtimer.go

Co-authored-by: Yun Long <[email protected]>

Co-authored-by: Yun Long <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
5 participants