Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support bi-directional service registry controllers #171

Merged
merged 15 commits into from
Aug 27, 2021
Merged

Support bi-directional service registry controllers #171

merged 15 commits into from
Aug 27, 2021

Conversation

xxx7xxxx
Copy link
Contributor

@xxx7xxxx xxx7xxxx commented Aug 8, 2021 •
edited
Loading

Related to megaease/easemesh#17

It's a draft for now. The framework and driver are done, it left a dedicated registry syncer for mesh and integration test to do.

megaeasex
megaeasex suggested changes Aug 8, 2021
View reviewed changes
Copy link

@megaeasex megaeasex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[TASK:easegress-pr-test FAILED]megaease/easegress Pull Request 171 Deploy Test failed

megaeasex
megaeasex approved these changes Aug 8, 2021
View reviewed changes
Copy link

@megaeasex megaeasex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[TASK:easegress-pr-test SUCCESS]megaease/easegress Pull Request 171 Deploy Test Success

@codecov-commenter
Copy link

codecov-commenter commented Aug 8, 2021 •
edited
Loading

Codecov Report

Merging #171 (ed0cb5d) into main (6b08bc7) will decrease coverage by 1.05%.
The diff coverage is 56.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #171      +/-   ##
==========================================
- Coverage   81.20%   80.14%   -1.06%     
==========================================
  Files          44       44              
  Lines        4846     4826      -20     
==========================================
- Hits         3935     3868      -67     
- Misses        694      738      +44     
- Partials      217      220       +3
Impacted Files Coverage Δ
pkg/object/meshcontroller/spec/spec.go 89.47% <0.00%> (-0.56%) ⬇️
pkg/cluster/cluster.go 48.76% <25.00%> (-1.41%) ⬇️
pkg/filter/proxy/server.go 70.58% <50.00%> (-23.66%) ⬇️
pkg/filter/proxy/pool.go 84.02% <85.71%> (+0.48%) ⬆️
pkg/filter/proxy/proxy.go 84.50% <100.00%> (-0.22%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b08bc7...ed0cb5d. Read the comment docs.

megaeasex
megaeasex suggested changes Aug 15, 2021
View reviewed changes
Copy link

@megaeasex megaeasex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[TASK:easegress-pr-test FAILED]megaease/easegress Pull Request 171 Deploy Test failed

megaeasex
megaeasex suggested changes Aug 15, 2021
View reviewed changes
Copy link

@megaeasex megaeasex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[TASK:easegress-pr-test FAILED]megaease/easegress Pull Request 171 Deploy Test failed

megaeasex
megaeasex approved these changes Aug 15, 2021
View reviewed changes
Copy link

@megaeasex megaeasex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[TASK:easegress-pr-test SUCCESS]megaease/easegress Pull Request 171 Deploy Test Success

@xxx7xxxx xxx7xxxx marked this pull request as ready for review August 15, 2021 16:17
megaeasex
megaeasex approved these changes Aug 19, 2021
View reviewed changes
Copy link

@megaeasex megaeasex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[TASK:easegress-pr-test SUCCESS]megaease/easegress Pull Request 171 Deploy Test Success

megaeasex
megaeasex approved these changes Aug 20, 2021
View reviewed changes
Copy link

@megaeasex megaeasex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[TASK:easegress-pr-test SUCCESS]megaease/easegress Pull Request 171 Deploy Test Success

megaeasex
megaeasex approved these changes Aug 20, 2021
View reviewed changes
Copy link

@megaeasex megaeasex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[TASK:easegress-pr-test SUCCESS]megaease/easegress Pull Request 171 Deploy Test Success

megaeasex
megaeasex approved these changes Aug 20, 2021
View reviewed changes
Copy link

@megaeasex megaeasex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[TASK:easegress-pr-test SUCCESS]megaease/easegress Pull Request 171 Deploy Test Success

megaeasex
megaeasex approved these changes Aug 20, 2021
View reviewed changes
Copy link

@megaeasex megaeasex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[TASK:easegress-pr-test SUCCESS]megaease/easegress Pull Request 171 Deploy Test Success

@benja-wu benja-wu requested review from localvar and benja-wu August 24, 2021 02:30
@benja-wu benja-wu added the enhancement New feature or request label Aug 24, 2021
@benja-wu benja-wu added this to the v1.3.0 milestone Aug 24, 2021
megaeasex
megaeasex approved these changes Aug 24, 2021
View reviewed changes
Copy link

@megaeasex megaeasex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[TASK:easegress-pr-test SUCCESS]megaease/easegress Pull Request 171 Deploy Test Success

megaeasex
megaeasex approved these changes Aug 24, 2021
View reviewed changes
Copy link

@megaeasex megaeasex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[TASK:easegress-pr-test SUCCESS]megaease/easegress Pull Request 171 Deploy Test Success

megaeasex
megaeasex approved these changes Aug 25, 2021
View reviewed changes
Copy link

@megaeasex megaeasex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[TASK:easegress-pr-test SUCCESS]megaease/easegress Pull Request 171 Deploy Test Success

megaeasex
megaeasex approved these changes Aug 25, 2021
View reviewed changes
Copy link

@megaeasex megaeasex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[TASK:easegress-pr-test SUCCESS]megaease/easegress Pull Request 171 Deploy Test Success

localvar
localvar reviewed Aug 27, 2021
View reviewed changes
@xxx7xxxx
Copy link
Contributor Author

Updated as comments

megaeasex
megaeasex suggested changes Aug 27, 2021
View reviewed changes
Copy link

@megaeasex megaeasex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[TASK:easegress-pr-test FAILED]megaease/easegress Pull Request 171 Deploy Test failed

megaeasex
megaeasex approved these changes Aug 27, 2021
View reviewed changes
Copy link

@megaeasex megaeasex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[TASK:easegress-pr-test SUCCESS]megaease/easegress Pull Request 171 Deploy Test Success

megaeasex
megaeasex approved these changes Aug 27, 2021
View reviewed changes
Copy link

@megaeasex megaeasex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[TASK:easegress-pr-test SUCCESS]megaease/easegress Pull Request 171 Deploy Test Success

benja-wu
benja-wu approved these changes Aug 27, 2021
View reviewed changes
Copy link
Contributor

@benja-wu benja-wu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@benja-wu benja-wu merged commit 91319d2 into easegress-io:main Aug 27, 2021
@xxx7xxxx xxx7xxxx deleted the mesh branch September 12, 2021 12:00
xmh19936688 pushed a commit to xmh19936688/easegress that referenced this pull request Sep 13, 2021
@xxx7xxxx @xmh19936688
Support bi-directional service registry controllers (easegress-io#171)
f62fc7b 
* [mesh]: Support bi-directional service registry controllers

* [mesh]: Add vendor

* [mesh]: Support nacos service registry

* [mesh]: Complete mesh registry syncer

* [mesh]: Use mutex pointer to copy

* [mesh]: Add more checking

* [doc]: Add NacosServiceRegistry

* [doc]: Add more document

* [mesh]: Add leader judgement for syncing

* [proxy]: Add dynamic service test

* [proxy]: Fix data race warning && Add service registry document

* Fix unit test

* Fix mod

* Fix close client in service registry drivers

* use a better name for dynamic servers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@localvar localvar localvar approved these changes

@benja-wu benja-wu benja-wu approved these changes

@megaeasex megaeasex megaeasex approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
v1.3.0
Development

Successfully merging this pull request may close these issues.
5 participants
@xxx7xxxx @codecov-commenter @localvar @benja-wu @megaeasex