You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
He folks I was reviewing this for possible use in another project and realized that the iris framework probably should be abandoned. As such I've made a quick pr (there is a few corners cut in the wait groups and signal handling) to bring the codebase under the go-chi http framework.
Please let me know if there is anything missing for this request #23
The text was updated successfully, but these errors were encountered:
@bigangryrobot First of all, thanks for your contribution. Your concern about no using iris framework seems reasonable for us. We will review your PR carefully.
BTW: Maybe we can start by opening and discussing in issue first, and then submit a PR next time. That would be better. :-)
@bigangryrobot Thanks so much raise this issue and PR, it's just the right time while we are looking for some possible alternatives recently. Thanks for this PR to lead us to make it real!
He folks I was reviewing this for possible use in another project and realized that the iris framework probably should be abandoned. As such I've made a quick pr (there is a few corners cut in the wait groups and signal handling) to bring the codebase under the go-chi http framework.
Please let me know if there is anything missing for this request
#23
The text was updated successfully, but these errors were encountered: