From bc02fde2367c257738bbf9b8ac2ad02cbe2a8f55 Mon Sep 17 00:00:00 2001
From: Harminder Virk <virk.officials@gmail.com>
Date: Fri, 14 Feb 2025 15:37:32 +0530
Subject: [PATCH] feat: allow all NodeSDK options via registerOtel (#11460)

---
 .changeset/kind-lobsters-swim.md             |  5 ++
 packages/medusa/src/instrumentation/index.ts | 51 ++++++++++++--------
 2 files changed, 35 insertions(+), 21 deletions(-)
 create mode 100644 .changeset/kind-lobsters-swim.md

diff --git a/.changeset/kind-lobsters-swim.md b/.changeset/kind-lobsters-swim.md
new file mode 100644
index 0000000000000..6a285a5d99734
--- /dev/null
+++ b/.changeset/kind-lobsters-swim.md
@@ -0,0 +1,5 @@
+---
+"@medusajs/medusa": patch
+---
+
+feat: allow all NodeSDK options via registerOtel
diff --git a/packages/medusa/src/instrumentation/index.ts b/packages/medusa/src/instrumentation/index.ts
index 3fad5a1ca2777..3a5344f16b4ea 100644
--- a/packages/medusa/src/instrumentation/index.ts
+++ b/packages/medusa/src/instrumentation/index.ts
@@ -8,7 +8,7 @@ import {
 import { ApiRoutesLoader } from "@medusajs/framework/http"
 import { Tracer } from "@medusajs/framework/telemetry"
 import type { SpanExporter } from "@opentelemetry/sdk-trace-node"
-import type { Instrumentation } from "@opentelemetry/instrumentation"
+import type { NodeSDKConfiguration } from "@opentelemetry/sdk-node"
 import { TransactionOrchestrator } from "@medusajs/framework/orchestration"
 
 const EXCLUDED_RESOURCES = [".vite", "virtual:"]
@@ -270,24 +270,34 @@ export function instrumentWorkflows() {
  * - @opentelemetry/instrumentation-pg
  * - @opentelemetry/instrumentation
  */
-export function registerOtel(options: {
-  serviceName: string
-  exporter: SpanExporter
-  instrument?: Partial<{
-    http: boolean
-    query: boolean
-    workflows: boolean
-    db: boolean
-  }>
-  instrumentations?: Instrumentation[]
-}) {
+export function registerOtel(
+  options: Partial<NodeSDKConfiguration> & {
+    serviceName: string
+    exporter?: SpanExporter
+    instrument?: Partial<{
+      http: boolean
+      query: boolean
+      workflows: boolean
+      db: boolean
+    }>
+  }
+) {
+  const {
+    exporter,
+    serviceName,
+    instrument,
+    instrumentations,
+    ...nodeSdkOptions
+  } = {
+    instrument: {},
+    instrumentations: [],
+    ...options,
+  }
+
   const { Resource } = require("@opentelemetry/resources")
   const { NodeSDK } = require("@opentelemetry/sdk-node")
   const { SimpleSpanProcessor } = require("@opentelemetry/sdk-trace-node")
 
-  const instrument = options.instrument || {}
-  const instrumentations = options.instrumentations || []
-
   if (instrument.db) {
     const { PgInstrumentation } = require("@opentelemetry/instrumentation-pg")
     instrumentations.push(new PgInstrumentation())
@@ -303,13 +313,12 @@ export function registerOtel(options: {
   }
 
   const sdk = new NodeSDK({
-    serviceName: options.serviceName,
-    resource: new Resource({
-      "service.name": options.serviceName,
-    }),
-    spanProcessor: new SimpleSpanProcessor(options.exporter),
+    serviceName,
+    resource: new Resource({ "service.name": serviceName }),
+    spanProcessor: new SimpleSpanProcessor(exporter),
+    ...nodeSdkOptions,
     instrumentations: instrumentations,
-  })
+  } satisfies Partial<NodeSDKConfiguration>)
 
   sdk.start()
   return sdk