enhance(ai-help): record embedding duration and model separately #458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
argl
reviewed
Apr 3, 2024
| @@ -108,44 +117,60 @@ pub async fn get_related_full_docs( | |||
| client: &Client<OpenAIConfig>, | |||
There was a problem hiding this comment.
Not related to this specific story, but is get_related_full_docs even used anywhere? I could not find any reference to it.
There was a problem hiding this comment.
Yes, indeed it's currently no longer used. I'll open a separate PR to remove it.
argl
reviewed
Apr 3, 2024
argl
reviewed
Apr 3, 2024
argl
approved these changes
Apr 3, 2024
Co-authored-by: Andi Pieper <[email protected]>
argl
approved these changes
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(MP-993)