Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plans to use netstandard or .NET Core #19

Open
joaoasrosa opened this issue Jul 24, 2018 · 12 comments
Open

Plans to use netstandard or .NET Core #19

joaoasrosa opened this issue Jul 24, 2018 · 12 comments

Comments

@joaoasrosa
Copy link

Hi,
Great work here! :)

There are any plans to support .NET Core, or at least be netstandard?

From a quick scan in the repo, the JSON dependency needs to be updated

Cheers

@mdevilliers
Copy link
Owner

Thanks,

I'm afraid to say that I don't do any .NET or C# in my day job so have let this project and my knowledge of the .NET world slip a bit. I do however have half an eye on whats going on but am pretty time poor at the moment.

I would love a PR if you had time ;-)

Thanks again,

Mark

@josephwoodward
Copy link

Might be interested in picking this up, just started using ToxiProxy and will need the .NET client. Looks fairly straight forward.

https://icanhasdot.net/result?github=mdevilliers~2FToxiproxy.Net

@josephwoodward
Copy link

I have a work in progress pull request of migrating this to .NET Standard

@mdevilliers
Copy link
Owner

Hey @josephwoodward Thanks for picking this up.
If I can be of any help of assistance please shout! (My email is in my profile)

Mark

@josephwoodward
Copy link

Thanks @mdevilliers, it's getting there.

All the tests are now passing on my Mac. I've had to bundle the Windows, Mac and Linux builds of the ToxiProxy server. Still a little bit more to go.

@matt-richardson
Copy link

Whats the latest on this port? I could do with a netcore version of this.
I'm happy to look at doing my own port if this PR has aborted.

@josephwoodward
Copy link

@matt-richardson It hasn't been aborted, it's almost done - I just haven't been able to commit much time to it lately. Would love some help to get it over the line though?

@matt-richardson
Copy link

Happy to help (though for the next couple of weeks I’m a bit time poor).
What’s outstanding?

@josephwoodward
Copy link

josephwoodward commented Sep 19, 2019

The work in progress PR is here, I can't remember exactly where I got up to with it. I think the next step was to launch the appropriate toxi server executable based on the runtime (I'll have to refresh my memory)

@adospace
Copy link

@mdevilliers from what I see @josephwoodward PR is ready to be accepted, no? even if tests won't work out of Windows it should be enough for now.
Sorry, we really need this library for a .net core 3 project, would be awesome if you could put some time in publishing the new .net standard version.

Thanks, great work BTW

@adospace
Copy link

For those interested I've recompiled the library to work in .net standard ( https://github.com/adospace/toxiproxy-netcore)

@zeotuan
Copy link

zeotuan commented May 22, 2023

@mdevilliers is this repo still maintained? I would like to maintain and upgrade this to .net 7.0. Using the upgrade based on @adospace derived repo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants