Skip to content
This repository has been archived by the owner on Feb 11, 2020. It is now read-only.

Fixed MongoDB retained messages #75

Merged
merged 13 commits into from
Dec 11, 2013
Merged

Fixed MongoDB retained messages #75

merged 13 commits into from
Dec 11, 2013

Conversation

ldstein
Copy link
Contributor

@ldstein ldstein commented Dec 10, 2013

This PR addresses:

There are also some additional changes to get Mosca building, running and passing all unit tests on Windows:

  • Bumped Microtime to 0.5.0 for Windows compatibility
  • Moved Async_bench to optional depencies (can't build on Windows)
  • Fixed "AfterEach" bug when running Unit tests on Windows
  • SIGHUP unit test ignored when OS is Windows based.

@ldstein
Copy link
Contributor Author

ldstein commented Dec 10, 2013

Damn you Travis :) I'll close this and check again what's going on.

@ldstein ldstein closed this Dec 10, 2013
@mcollina
Copy link
Collaborator

This is huge! Thanks! I'll review this in the next few days!

@mcollina
Copy link
Collaborator

Leave it open! I'll have a look too.. it might be a spurious failure coming up.

@ldstein ldstein reopened this Dec 10, 2013
@ldstein
Copy link
Contributor Author

ldstein commented Dec 10, 2013

The AfterEach bug is occuring in mosca/lib/client.js. See ldstein@3d85359

There is an end event listener added to connection.stream. If the stream is destroyed/being destroyed, the event never fires, hence the timeout. I added a check to see if the stream is destroyed - though I don't think destroyed is a consistent property on a Stream Object.

Good new is it's working on Windows. Bad news is it's failing on Linux, lol.

I'll do some more digging. The MongoDB / Windows stuff is working though.

@ldstein
Copy link
Contributor Author

ldstein commented Dec 10, 2013

Happy to report Mosca unit tests now pass on both Linux and Windows

@mcollina mcollina merged commit d20bdc9 into moscajs:master Dec 11, 2013
@mcollina
Copy link
Collaborator

Thanks again!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants